-
Notifications
You must be signed in to change notification settings - Fork 173
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix!: Make BinUtility constructor explicit (#3953)
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced JSON serialization and deserialization for material types, including robust handling for binned materials. - Improved error handling for unsupported binning configurations during JSON conversion. - Updated constructor for `BinUtility` to prevent implicit conversions. - **Bug Fixes** - Adjusted grid index type assignment based on binning values to prevent runtime errors. - Improved error handling and logging in material conversion processes. - **Tests** - Updated test cases for `BinUtility` initialization to improve clarity without altering functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
- Loading branch information
1 parent
d6eb834
commit f3e3997
Showing
4 changed files
with
9 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters