-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure ODD cleanup if sequencer stops in Examples Python tests #3471
fix: Ensure ODD cleanup if sequencer stops in Examples Python tests #3471
Conversation
Sadly it still crashes |
|
It seems to only happen when the test fails. If I catch the exception and go on and let the test succeed there is no problem. It somehow seems like a pytest problem to me. Do you see a way to surround the problem @paulgessinger ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Might have to revisit how we close file handles at the end of the sequencer run.
Quality Gate passedIssues Measures |
Looks like pytest will hold on to all the local variables in case a test fails. This becomes a problem if the ODD was constructed and will be constructed in a consecutive test as only one instance can be in flight 🙄