Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update compiler warning flags #3495

Merged
merged 28 commits into from
Aug 20, 2024
Merged

chore: Update compiler warning flags #3495

merged 28 commits into from
Aug 20, 2024

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Aug 8, 2024 •
edited
Loading

  • Remove -Wno-unused-local-typedefs

  • Add -Wzero-as-null-pointer-constant, -Wold-style-cast and -Wnull-derefence

  • Fix warnings caused by these flags

  • This requires an update to ODD, since ODD triggers old-style cast warnings currently.

  • Depends on fix: Avoid unused local typedef actsvg#80 to avoid warnings from ACTSVG

Blocked by

@paulgessinger paulgessinger added this to the next milestone Aug 8, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Vertexing Track Finding Track Fitting labels Aug 8, 2024
stephenswat
stephenswat previously approved these changes Aug 8, 2024
View reviewed changes
@paulgessinger paulgessinger mentioned this pull request Aug 9, 2024
Merged
@acts-policybot acts-policybot bot dismissed stephenswat’s stale review August 14, 2024 07:28

Invalidated by push of c16685b

@paulgessinger paulgessinger force-pushed the chore/warning-reduction branch 3 times, most recently from e8e989a to facbefe Compare August 14, 2024 12:35
@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Aug 14, 2024
@github-actions github-actions bot added Component - Fatras Affects the Fatras module Component - Documentation Affects the documentation labels Aug 15, 2024
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Aug 16, 2024
@paulgessinger paulgessinger marked this pull request as ready for review August 16, 2024 07:25
@github-actions github-actions bot removed Component - Fatras Affects the Fatras module Component - Documentation Affects the documentation labels Aug 16, 2024
andiwand
andiwand approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Core/include/Acts/Propagator/DenseEnvironmentExtension.hpp Show resolved Hide resolved
Core/include/Acts/Definitions/Algebra.hpp Show resolved Hide resolved
thirdparty/OpenDataDetector Outdated Show resolved Hide resolved
andiwand
andiwand approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get this in!

@kodiakhq kodiakhq bot merged commit 77d1f88 into acts-project:main Aug 20, 2024
41 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 20, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
41.2% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarCloud

@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [77d1f88]

🔴 Some tests have failed!

Please investigate the pipeline!

status job report
🔴 run_unit_tests
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 test_ActsDumpGeometryIdentifiers
🔴 test_ActsCheckObjectCountsCachedWorkflow
🔴 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🔴 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Aug 21, 2024
@CouthuresJeremy CouthuresJeremy mentioned this pull request Aug 21, 2024
Merged
@paulgessinger paulgessinger modified the milestones: next, v36.2.0 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenswat stephenswat stephenswat left review comments

@andiwand andiwand andiwand approved these changes

@AJPfleger AJPfleger Awaiting requested review from AJPfleger

Assignees
No one assigned
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Event Data Model Fails Athena tests This PR causes a failure in the Athena tests Infrastructure Changes to build tools, continous integration, ... Track Finding Track Fitting Vertexing
Projects
None yet
Milestone
v36.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@paulgessinger @acts-project-service @andiwand @stephenswat