-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor and generalize propagation validation #3514
feat: refactor and generalize propagation validation #3514
Conversation
@asalzburger can you describe what this is about?
We bumped clang-format to v18. I recommend you set up pre-commit and use that for formatting. |
Also, I think @andiwand wanted to circle back around to this. He should be back Monday, surely we can wait until then with this? |
Yes, no problem, I though I would take some work off his shoulders, because the main rebasing is coming from the input change to particle gun, which I authored. |
ab888a5
to
7e06d00
Compare
Quality Gate passedIssues Measures |
This supersedes #3434 and rebases it onto the latest updates of the propagation example.
This changes the output from a simple step collection from the propagation example to a
PropagationSummary
object,which contains the input parameters and the step collections.
with this, the
RootPropgationStepWriter
and the newRootPropagationSummaryWriter
can now easily write out information of the propagation job and relate them to the start parameterswriting out the
PropagationSummary
will eventually allow to have aDirectPropagationAlgorithm
(version) and aTryAllPropagationAlgorithm
(version) which can sandwich thePropagationAlgorithm
and will give us information about:potential navigation failures versus brute-force navigation
overhead of navigation wrt direct propagation