Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor and generalize propagation validation #3514

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Aug 16, 2024

This supersedes #3434 and rebases it onto the latest updates of the propagation example.

This changes the output from a simple step collection from the propagation example to a PropagationSummary object,
which contains the input parameters and the step collections.

  • with this, the RootPropgationStepWriter and the new RootPropagationSummaryWriter can now easily write out information of the propagation job and relate them to the start parameters

  • writing out the PropagationSummary will eventually allow to have a DirectPropagationAlgorithm (version) and a TryAllPropagationAlgorithm (version) which can sandwich the PropagationAlgorithm and will give us information about:

  • potential navigation failures versus brute-force navigation

  • overhead of navigation wrt direct propagation

@paulgessinger
Copy link
Member

paulgessinger commented Aug 16, 2024

@asalzburger can you describe what this is about?

  • What does this do?
  • Why is it needed?

We bumped clang-format to v18. I recommend you set up pre-commit and use that for formatting.

@github-actions github-actions bot removed Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Vertexing Seeding labels Aug 16, 2024
@paulgessinger
Copy link
Member

Also, I think @andiwand wanted to circle back around to this. He should be back Monday, surely we can wait until then with this?

Copy link

github-actions bot commented Aug 16, 2024

📊: Physics performance monitoring for 0d6644d

Full contents

physmon summary

@asalzburger
Copy link
Contributor Author

Also, I think @andiwand wanted to circle back around to this. He should be back Monday, surely we can wait until then with this?

Yes, no problem, I though I would take some work off his shoulders, because the main rebasing is coming from the input change to particle gun, which I authored.

@asalzburger asalzburger force-pushed the ex-refactor-and-generalize-propagation-validation branch from ab888a5 to 7e06d00 Compare August 20, 2024 11:11
Copy link

sonarcloud bot commented Aug 21, 2024

@kodiakhq kodiakhq bot merged commit 7c27231 into acts-project:main Aug 21, 2024
44 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [7c27231]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Aug 21, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.2.0 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Changes Performance Component - Documentation Affects the documentation Component - Examples Affects the Examples module Event Data Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants