Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Gen 3 portal shells #3564

Merged
merged 26 commits into from
Oct 4, 2024
Merged

feat: Gen 3 portal shells #3564

merged 26 commits into from
Oct 4, 2024

Commits on Oct 2, 2024

  1. --------------------------------------------

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    691f991 View commit details
    Browse the repository at this point in the history

  2. shell: experimenting with portal shell 

    fixup: PortalShell.cpp in cmakelists
    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2a70b7d View commit details
    Browse the repository at this point in the history

  3. shell: move size to cpp

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2ab4c72 View commit details
    Browse the repository at this point in the history

  4. shell: implement merging by portal shell

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    5d05a08 View commit details
    Browse the repository at this point in the history

  5. shell: stack shell does fusing

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0447ac6 View commit details
    Browse the repository at this point in the history

  6. shell: Include new portalLinkbase header

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1fe9f6a View commit details
    Browse the repository at this point in the history

  7. shell: Take geometry context where needed

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    47397d1 View commit details
    Browse the repository at this point in the history

  8. shell: Rename PortalShell to PortalShellBase

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    68bf6e8 View commit details
    Browse the repository at this point in the history

  9. shell: Rename CylinderPortalShell to CylinderPortalShellBase

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    51257c0 View commit details
    Browse the repository at this point in the history

  10. shell: resolveVolume returns Result

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    767b4d3 View commit details
    Browse the repository at this point in the history

  11. shell: remove gctx from shell construction

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    5e7e8e8 View commit details
    Browse the repository at this point in the history

  12. shell: change argument checks, test them

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    df16c2c View commit details
    Browse the repository at this point in the history

  13. refactor(geo): Rename CylinderPortalShellBase to CylinderPortalShell

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4da83c1 View commit details
    Browse the repository at this point in the history

  14. feat(geo): Add method to connect all outer links on portal 

    This works for single cylinders and for cylinder stacks
    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    7eea785 View commit details
    Browse the repository at this point in the history

  15. shell: Sanity checks and outputs

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    b73481a View commit details
    Browse the repository at this point in the history

  16. shell: Stack shell can construct from single shell, output improvements

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    85828ce View commit details
    Browse the repository at this point in the history

  17. refactor(geo): PortalShell portal access returns nullptr 

    E.g. the cylinder stack shell will return nullptr on phi plane portal
access, instead of throwing an exception.
    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    74f6928 View commit details
    Browse the repository at this point in the history

  18. shell: Changes to portal registration

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8c3e3fc View commit details
    Browse the repository at this point in the history

  19. shell: add fallthrough markup

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    556f254 View commit details
    Browse the repository at this point in the history

  20. shell: Fix missing loop for portal assignment (lots of asserts)

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1858a46 View commit details
    Browse the repository at this point in the history

  21. shell: Add doc comments

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    93b50fe View commit details
    Browse the repository at this point in the history

  22. shell: Update illustration

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e9d87bf View commit details
    Browse the repository at this point in the history

  23. shell: Update illustration again

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e2583b4 View commit details
    Browse the repository at this point in the history

  24. shell: fix doc comment

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    33acb0d View commit details
    Browse the repository at this point in the history

  25. shell: Fix a few sonar issues

    @paulgessinger
    paulgessinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    7e079e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Merge branch 'main' into feat/gen3-portal-shells

    @kodiakhq
    kodiakhq[bot] authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d42695d View commit details
    Browse the repository at this point in the history