refactor: use mathematical constants from std::numbers
#3781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
asalzburger
previously approved these changes
Nov 5, 2024
Examples/Algorithms/TrackFinding/include/ActsExamples/TrackFinding/HoughTransformSeeder.hpp
Show resolved
Hide resolved
Fatras/include/ActsFatras/Physics/ElectroMagnetic/detail/GaussianMixture.hpp
Show resolved
Hide resolved
CarloVarni
reviewed
Nov 5, 2024
Examples/Detectors/MuonSpectrometerMockupDetector/src/MockupSectorBuilder.cpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/MuonSpectrometerMockupDetector/src/MockupSectorBuilder.cpp
Outdated
Show resolved
Hide resolved
|
@AJPfleger some comments from my side. As a general rule though (just a tip): 100 small PRs are much better than a single giant PR. Small PRs are much easier to review (review time is very small, and I see that reviewers have the tendency to delay big PRs) and smaller chance of merge conflicts. |
|
Do you wanna make a |
I prepared a check: That one only checks for macros. I tried to also replace values like |
CarloVarni
approved these changes
Nov 10, 2024
|
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
The firstly intended clang tidy check `modernize-use-std-numbers` is not suited for us: - it doesn't flag macros like `M_PI` - it flags values in our tables that get close to constants, which have a different basis. benefit would have been to detect cases like `static_cast<float>(std::numbers::pi)` instead of `std::numbers::pi_v<float>` or usages of `std::sqrt(2.)` instead of `std::numbers::sqrt2`. The updated test now checks for the classical `M_*` macros that could be accidentally used. blocked: - #3781
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
…t#3781) blocked: - acts-project#3783 Asked co-pilot to summarise the PR: Summary: The pull request aims to refactor the code to use mathematical constants from the C++20 <numbers> header, replacing existing instances of M_PI with std::numbers::pi. The changes span multiple files, primarily focusing on improving the consistency and modernity of mathematical constant usage across the codebase.
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
The firstly intended clang tidy check `modernize-use-std-numbers` is not suited for us: - it doesn't flag macros like `M_PI` - it flags values in our tables that get close to constants, which have a different basis. benefit would have been to detect cases like `static_cast<float>(std::numbers::pi)` instead of `std::numbers::pi_v<float>` or usages of `std::sqrt(2.)` instead of `std::numbers::sqrt2`. The updated test now checks for the classical `M_*` macros that could be accidentally used. blocked: - acts-project#3781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked:
Asked co-pilot to summarise the PR:
Summary:
The pull request aims to refactor the code to use mathematical constants from the C++20 header, replacing existing instances of M_PI with std::numbers::pi. The changes span multiple files, primarily focusing on improving the consistency and modernity of mathematical constant usage across the codebase.