Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Estimate parameters on surface also if bottom SP is not on surface #3800

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andiwand
Copy link
Contributor

The interface of

template <typename spacepoint_iterator_t>
std::optional<BoundVector> estimateTrackParamsFromSeed(
    const GeometryContext& gctx, spacepoint_iterator_t spBegin,
    spacepoint_iterator_t spEnd, const Surface& surface, const Vector3& bField,
    ActsScalar bFieldMin, const Acts::Logger& logger = getDummyLogger()) {

suggests that the parameters will be estimated on any surface. The doc is making this clear but we also had multiple cases when this would be useful.

Generally a spacepoint does not need to be on surface. For example for combined strip space points this is not the case.

@andiwand andiwand added this to the next milestone Oct 31, 2024
@andiwand
Copy link
Contributor Author

andiwand commented Oct 31, 2024

@github-actions github-actions bot added Component - Core Affects the Core module Seeding labels Oct 31, 2024
@benjaminhuth
Copy link
Member

would be very useful! 👍

Copy link

📊: Physics performance monitoring for 5a9eb62

Full contents

physmon summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Seeding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants