-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Reworked HitSelector
in Examples
#3836
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This helper is not used anywhere and should be either removed or made use of. I opted to remove it for now as finding all the spots where it could be used is much more tedious and time consuming. Discovered in #3836
Quality Gate passedIssues Measures |
MeasurementSelector
and reworked HitSelector
for ExamplesHitSelector
for Examples
HitSelector
for ExamplesHitSelector
in Examples
This helper is not used anywhere and should be either removed or made use of. I opted to remove it for now as finding all the spots where it could be used is much more tedious and time consuming. Discovered in acts-project#3836
The motivations is that one can select hits to constrain the reconstruction to a subset of them. This can be especially useful for studies which look at different pile-up. Pile-up vertices have consecutive primary vertex IDs so one can simulate for example pile-up 200 and then reconstruct only a subset of them.
Bocked by
CalculateResiduals.hpp
#3837