chore: Newline after #pragma once
#3997
Conversation
WalkthroughThe pull request introduces a comprehensive set of new header files and classes across multiple namespaces in the ACTS project, focusing on geometry, magnetic field management, surfaces, and utilities. The changes span core libraries and plugins, adding new interfaces, implementing utility classes, and enhancing existing functionality with more flexible and robust implementations. Changes
Sequence DiagramsequenceDiagram
participant MagneticFieldProvider
participant ConstantBField
participant MultiRangeBField
participant NullBField
MagneticFieldProvider->>ConstantBField: Implement constant field
MagneticFieldProvider->>MultiRangeBField: Support multiple field ranges
MagneticFieldProvider->>NullBField: Provide zero field implementation
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
Component - Core
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
Core/include/Acts/Surfaces/LineSurface.hpp (1)
10-10: Newline after #pragma once, add you must.
Consistent formatting, it will promote.Apply this diff:
#pragma once +Core/include/Acts/Surfaces/SurfaceArray.hpp (1)
10-10: Newline after #pragma once, place you must.
Smooth reading, it shall ensure.Apply this diff:
#pragma once +Plugins/Onnx/include/Acts/Plugins/Onnx/OnnxRuntimeBase.hpp (1)
10-10: A blank line after #pragma once, add you should.
Orderly code style, it creates.Apply this diff:
#pragma once +Core/include/Acts/Utilities/ThrowAssert.hpp (1)
10-10: After #pragma once, an extra newline you must insert.
Uniform code formatting we achieve, mm?Apply this diff:
#pragma once +Core/include/Acts/Seeding/HoughTransformUtils.hpp (1)
Line range hint
160-168: Additional widthPar parameter, powerful extension it is.
Expanding flexibility in binning logic, the extra function provides. Careful to document usage in Doxygen you should, so other Jedi on the project clarity have.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (27)
Core/include/Acts/Geometry/IConfinedTrackingVolumeBuilder.hpp(1 hunks)Core/include/Acts/Geometry/ITrackingGeometryBuilder.hpp(1 hunks)Core/include/Acts/Geometry/ProtoLayer.hpp(1 hunks)Core/include/Acts/MagneticField/BFieldMapUtils.hpp(1 hunks)Core/include/Acts/MagneticField/ConstantBField.hpp(1 hunks)Core/include/Acts/MagneticField/MultiRangeBField.hpp(1 hunks)Core/include/Acts/MagneticField/NullBField.hpp(1 hunks)Core/include/Acts/Seeding/HoughTransformUtils.hpp(1 hunks)Core/include/Acts/Surfaces/DiscTrapezoidBounds.hpp(1 hunks)Core/include/Acts/Surfaces/LineSurface.hpp(1 hunks)Core/include/Acts/Surfaces/PerigeeSurface.hpp(1 hunks)Core/include/Acts/Surfaces/SurfaceArray.hpp(1 hunks)Core/include/Acts/Surfaces/SurfaceBounds.hpp(1 hunks)Core/include/Acts/Surfaces/TrapezoidBounds.hpp(1 hunks)Core/include/Acts/Utilities/BinnedArray.hpp(1 hunks)Core/include/Acts/Utilities/BinnedArrayXD.hpp(1 hunks)Core/include/Acts/Utilities/BinningType.hpp(1 hunks)Core/include/Acts/Utilities/ThrowAssert.hpp(1 hunks)Core/include/Acts/Utilities/detail/RealQuadraticEquation.hpp(1 hunks)Core/include/Acts/Vertexing/AdaptiveGridTrackDensity.hpp(1 hunks)Core/include/Acts/Vertexing/GaussianGridTrackDensity.hpp(1 hunks)Plugins/DD4hep/include/Acts/Plugins/DD4hep/DD4hepVolumeBuilder.hpp(1 hunks)Plugins/Legacy/include/Acts/Seeding/AtlasSeedFinder.hpp(1 hunks)Plugins/Legacy/include/Acts/Seeding/LegacyInternalSeed.hpp(1 hunks)Plugins/Legacy/include/Acts/Seeding/LegacySeed.hpp(1 hunks)Plugins/Legacy/include/Acts/Seeding/SPForSeed.hpp(1 hunks)Plugins/Onnx/include/Acts/Plugins/Onnx/OnnxRuntimeBase.hpp(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- Core/include/Acts/Geometry/ITrackingGeometryBuilder.hpp
- Core/include/Acts/Geometry/IConfinedTrackingVolumeBuilder.hpp
- Core/include/Acts/Utilities/BinningType.hpp
🧰 Additional context used
📓 Learnings (1)
Core/include/Acts/MagneticField/BFieldMapUtils.hpp (1)
Learnt from: AJPfleger
PR: acts-project/acts#3615
File: Core/src/MagneticField/BFieldMapUtils.cpp:214-231
Timestamp: 2024-12-02T10:20:44.377Z
Learning: In the C++ file `Core/src/MagneticField/BFieldMapUtils.cpp`, when passing methods to constructors in functions like `fieldMapRZ` and `solenoidFieldMap`, prefer to define transforms in each function separately for clarity, even if the methods are similar.
🔇 Additional comments (21)
Core/include/Acts/Utilities/BinnedArray.hpp (1)
14-14: Hmmm, spacing aligned properly after pragma once, it is.
A uniform style throughout the codebase, we must maintain.
Core/include/Acts/Utilities/BinnedArrayXD.hpp (1)
14-14: Newline after pragma once, good practice it is.
Approved, this alignment is.
Plugins/Legacy/include/Acts/Seeding/AtlasSeedFinder.hpp (1)
14-14: Hmmm, maintain clarity, this does.
A newline after "#pragma once" ensures neatness, yes. Enhances readability, it does.
Plugins/Legacy/include/Acts/Seeding/LegacySeed.hpp (1)
14-14: Helpful, this small change is.
Preserves formatting consistency, it does. Newline after pragma once, a fine practice it is.
Plugins/Legacy/include/Acts/Seeding/LegacyInternalSeed.hpp (1)
14-14: Aligned with standard conventions, this is.
Yes, keep the codebase tidy, we must.
Plugins/Legacy/include/Acts/Seeding/SPForSeed.hpp (1)
14-14: Commendable, the spacing after pragma once is.
Yes, fosters cleanliness in the structure, hmm.
Core/include/Acts/MagneticField/MultiRangeBField.hpp (1)
10-10: A mere newline after #pragma once, hmm. An improvement, it is.
Align with the style guidelines, this does. No issues I see. Approve the change, I do.
Core/include/Acts/Surfaces/TrapezoidBounds.hpp (1)
10-10: New line, yes. Good for readability, it is.
Enhance clarity, such a small change does.
Core/include/Acts/Surfaces/DiscTrapezoidBounds.hpp (1)
10-10: After #pragma once, a space you add.
Consistent with a neat code layout, this is. No concerns have I.
Core/include/Acts/Vertexing/AdaptiveGridTrackDensity.hpp (1)
10-10: A new line you inserted, wise choice.
Maintain code style, such changes will. Continue, you must.
Core/include/Acts/Utilities/detail/RealQuadraticEquation.hpp (1)
13-14: Approve this change, I do!
Consistent with coding style, the newline after #pragma once is. Improved readability, it has!
Core/include/Acts/MagneticField/NullBField.hpp (1)
9-10: Approve this change too, I must!
A newline after #pragma once, added it has been. Good separation between preprocessor directives and includes, this provides!
Core/include/Acts/Surfaces/SurfaceBounds.hpp (1)
9-10: Approve this change as well, we shall!
The Force is strong with this one! A newline after #pragma once, properly placed it is.
Core/include/Acts/MagneticField/ConstantBField.hpp (1)
10-10: Approve newline addition after pragma once, hmm yes.
Improved readability, this change has. Consistent with coding style guidelines, it is.
Core/include/Acts/Surfaces/PerigeeSurface.hpp (1)
10-10: Approve newline addition after pragma once, I do.
Clarity to the Force, this newline brings. Good separation between header guard and includes, it provides.
Plugins/DD4hep/include/Acts/Plugins/DD4hep/DD4hepVolumeBuilder.hpp (1)
10-10: Approve newline addition after pragma once, we must.
Balance to the code structure, this newline brings. Consistent with the other files, it now is.
Core/include/Acts/Geometry/ProtoLayer.hpp (1)
9-10: Approve this change, I do!
Improved readability between pragma directive and includes, this newline brings. Consistent with coding style guidelines, it is.
Core/include/Acts/MagneticField/BFieldMapUtils.hpp (1)
9-10: Approve this change, I do!
A clear separation between pragma and includes, this newline creates. Consistent with other files in the codebase, it remains.
Core/include/Acts/Vertexing/GaussianGridTrackDensity.hpp (1)
9-10: Approve this change, I do!
Better readability between pragma and includes, this newline provides. Maintains consistency across the codebase, it does.
Core/include/Acts/Seeding/HoughTransformUtils.hpp (2)
12-12: Newline after #pragma once, good practice it is.
A neat separation from the includes you have provided, hmmm. Clarity and consistency, improved they are.
Line range hint 73-73: New getter method for hits, reveal its potential it does.
Yes, returns a span of identifies, mm? Ensure usage across codebase is correct and thoroughly tested, you should. Save time in debugging, it will.
|
Summary by CodeRabbit
New Features
Bug Fixes
SPForSeedclass to improve error correction for space points.Documentation
Chores