Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coordinates and Refactor all classes based on transform_type #291

Merged
merged 11 commits into from
Sep 23, 2022

Conversation

beomki-yeo
Copy link
Collaborator

@beomki-yeo beomki-yeo commented Aug 21, 2022

This PR is still on halfway. (Depends on acts-project/algebra-plugins#73)

Changes are (will be) the following:

  1. Refactor the most classes with transform3 and track_indices as template parameters. By doing this we will be able to write unit test for different plugins in single compilation
  2. Migrate coordinates from algebra-plguins
  3. (WIP) Add some more detector kernel functions to utilize the functions of coordinate.

UPDATE on Aug 22nd:
The PR is ready to be reviewed. (But depends on acts-project/algebra-plugins#73.) The changes are the following:

  • As we discussed today, I used the single header file for the track indices defined with std::size_t
  • Coordinate types are rewritten with CRTP pattern.
  • Jacobian transformation of coordinates is still missing but it will be added in the next PR
  • The original covariance_engine is now disabled so some related tests are also commented. They will be rewritten with the coordinate-specific jacobian transformation and type unrolling

@beomki-yeo beomki-yeo marked this pull request as draft August 21, 2022 00:19
@beomki-yeo beomki-yeo changed the title Add coordinates and Refactor all classes based on transform_type and track_indices_type Add coordinates and Refactor all classes based on transform_type Aug 23, 2022
@beomki-yeo beomki-yeo marked this pull request as ready for review August 23, 2022 00:05
core/include/detray/coordinates/cartesian2.hpp Outdated Show resolved Hide resolved
core/include/detray/coordinates/cartesian2.hpp Outdated Show resolved Hide resolved
core/include/detray/tracks/detail/track_helper.hpp Outdated Show resolved Hide resolved
core/include/detray/intersection/detail/trajectories.hpp Outdated Show resolved Hide resolved
core/include/detray/tracks/free_track_parameters.hpp Outdated Show resolved Hide resolved
extern/algebra-plugins/CMakeLists.txt Outdated Show resolved Hide resolved
extern/benchmark/CMakeLists.txt Show resolved Hide resolved
Copy link
Contributor

@niermann999 niermann999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed

@beomki-yeo beomki-yeo merged commit 8c6597b into acts-project:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants