-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coordinates and Refactor all classes based on transform_type
#291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beomki-yeo
changed the title
Add coordinates and Refactor all classes based on
Add coordinates and Refactor all classes based on Aug 23, 2022
transform_type
and track_indices_type
transform_type
beomki-yeo
force-pushed
the
add-coordinates
branch
from
August 23, 2022 01:03
fcb5d55
to
7e944cc
Compare
niermann999
reviewed
Sep 7, 2022
niermann999
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still on halfway. (Depends on acts-project/algebra-plugins#73)
Changes are (will be) the following:
transform3
andtrack_indices
as template parameters. By doing this we will be able to write unit test for different plugins in single compilationUPDATE on Aug 22nd:
The PR is ready to be reviewed. (But depends on acts-project/algebra-plugins#73.) The changes are the following:
std::size_t
covariance_engine
is now disabled so some related tests are also commented. They will be rewritten with the coordinate-specific jacobian transformation and type unrolling