Replace constant magnetic field with covfie fields #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
changed the title
niermann999
reviewed
Oct 11, 2022
tests/common/include/tests/common/check_geometry_navigation.inl
Outdated
Show resolved
Hide resolved
| // Use rectangular surfaces | ||
| constexpr bool rectangular = false; | ||
|
|
||
| using b_field_t = decltype(create_telescope_detector<rectangular>(std::declval<vecmem::host_memory_resource&>(), std::declval<std::vector<scalar>&>()))::bfield_type; |
There was a problem hiding this comment.
Yes, same goes for the telescope of course, but I have to fix that detector anyways, so I will look into this
| @@ -273,8 +276,12 @@ auto create_telescope_detector( | |||
| scalar m_thickness; | |||
| }; | |||
|
|
|||
| typename detector_t::bfield_type bfield( | |||
There was a problem hiding this comment.
Ah, nice, then I just have to make it configurable somehow
|
Do you mind if we merge #294 first though? |
|
Of course! |
stephenswat
force-pushed
the
feat/covfie_constant_field
branch
from
f53d1a2 to
23e2466
Compare
|
This PR has been rebased. |
stephenswat
force-pushed
the
feat/covfie_constant_field
branch
3 times, most recently
from
80027fa to
1c36017
Compare
|
Formatting has been adjusted, all tests pass. |
stephenswat
force-pushed
the
feat/covfie_constant_field
branch
2 times, most recently
from
9229a6a to
e46a5be
Compare
This change migrates all existing usage of magnetic fields -- all constant -- to use the covfie library. From here, integrating analytical solenoidal fields or data-based fields should be (relatively) trivial.
stephenswat
force-pushed
the
feat/covfie_constant_field
branch
from
e46a5be to
0b5d29b
Compare
niermann999
reviewed
Oct 12, 2022
| @@ -37,7 +37,6 @@ class rk_stepper final | |||
| using point3 = typename transform3_type::point3; | |||
| using vector2 = typename transform3_type::point2; | |||
| using vector3 = typename transform3_type::vector3; | |||
| using context_type = typename magnetic_field_t::context_type; | |||
There was a problem hiding this comment.
I will have a look shortly how to handle the context objects, so let's see
niermann999
reviewed
Oct 12, 2022
| const auto d = create_toy_geometry(host_mr, n_brl_layers, n_edc_layers); | ||
|
|
||
| // Construct the constant magnetic field. | ||
| using b_field_t = decltype( |
There was a problem hiding this comment.
Now we just need to find a way to make the backend configurable from here, but let's do that when we switch to the solenoid
|
Let's get this in asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change migrates all existing usage of magnetic fields -- all constant -- to use the covfie library. From here, integrating analytical solenoidal fields or data-based fields should be relatively trivial.