Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traccc tuple and pair types #814

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

stephenswat
Copy link
Member

This commit replaces the Thrust tuple and pair types from the traccc core library, as this dependency on Thrust is causing a lot of build headaches. Since we use the Thrust dependencies very sparsely in core, it is easier to remove them than to try to work around them.

@stephenswat stephenswat added the cleanup Makes the code all clean and tidy label Jan 21, 2025
@stephenswat stephenswat added refactor Change the structure of the code shared Changes related to shared code and removed cleanup Makes the code all clean and tidy labels Jan 21, 2025
@stephenswat
Copy link
Member Author

Note that this is basically detray::tuple.

core/include/traccc/edm/details/container_base.hpp Outdated Show resolved Hide resolved
core/include/traccc/utils/tuple.hpp Show resolved Hide resolved
This commit replaces the Thrust tuple and pair types from the traccc
core library, as this dependency on Thrust is causing a lot of build
headaches. Since we use the Thrust dependencies very sparsely in core,
it is easier to remove them than to try to work around them.
@stephenswat stephenswat enabled auto-merge January 22, 2025 12:01
@stephenswat stephenswat merged commit 62bb956 into acts-project:main Jan 22, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Change the structure of the code shared Changes related to shared code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants