Add tests for momentum resolution validation #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beomki-yeo
force-pushed
the
mom-resolution-test
branch
6 times, most recently
from
ec715df to
82d40ca
Compare
beomki-yeo
force-pushed
the
mom-resolution-test
branch
from
f522e45 to
a028676
Compare
stephenswat
approved these changes
Jan 23, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test suite to validate the momentum resolution of Kalman fitting against the theoretical estimation in the telescope geometry. The momentum resolution, i.e. the sigma of q/pT residuals is affected by detector noise and the multiple scattering in the material. In the implemented tests, we only test the term from the detector noise by setting the materials to vacuum. The discrepancy is less than 5% for all cases tested.
The theoretical estimation can be found in section 35.13 of PDG 2024. As mentioned, we are only comparing with the term from detector noise, corresponding to Eq. (35.61)
Also shoutout to Liangrui (@LiliryCC) who has significantly contributed to this validation behind the scenes 😉