CI Fix / Update, main branch (2024.11.28.) #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to do this, removed the Ubuntu 18.04 based builds. Replaced them with Ubuntu 20.04 based ones, which would still ask for the same C++ standards as the 18.04 ones.
|
stephenswat
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft decided to update
checkout@v3in such a way that it's no longer compatible with our legacy Ubuntu 18.04 images. 😢 Which we just couldn't find a (reasonable) solution for with @stephenswat.So this removes the Ubuntu 18.04 builds finally, replacing them with Ubuntu 20.04 ones. While keeping the same C++ standards that the Ubuntu 18.04 builds were using.
At the same time updated all the container based builds to
checkout@v4, since at this point we might as well use that. Apparently it anyways doesn't mean much, as tagged versions of the actions can still get updated under one's feet... 😦