Increased default batch size and corrected a bug where id filter woul…

…d not increment in the RESTlet
acumenbrands · May 7, 2012 · c58888c · c58888c
1 parent 30c13c8
commit c58888c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/lib/netsuite-rest-client.rb b/lib/netsuite-rest-client.rb
@@ -139,7 +139,6 @@ def get_saved_search(record_type, search_id, options={})
       end
 
       begin
-        puts params['batch_size']
         results_segment, params['start_id'] = *parse_json_result_from_rest(:get, params)
         results_segment.class == Array ? results += results_segment : raise("Search error: #{results_segment}")
         puts "Fetched #{results.count} records so far, querying from #{params['start_id']}..." if options[:verbose]

diff --git a/lib/restlets/rest.js b/lib/restlets/rest.js
@@ -286,6 +286,7 @@ function getSavedSearch(request) {
         var tempItems = nlapiSearchRecord(recordType, searchId, searchFilters, returnColumns);
         if(tempItems) {
             lowerBound = tempItems[tempItems.length - 1].getId();
+            searchFilters      = [new nlobjSearchFilter('internalidnumber', null, 'greaterthan', lowerBound)];
             accumulatedResults = accumulatedResults.concat(tempItems);
         }
     } while(tempItems && tempItems.length == 1000 && accumulatedResults.length < batchSize);