This repository has been archived by the owner on May 2, 2023. It is now read-only.
Search filter join support #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has become mandatory, needs a default ? to keep compatibility with existing script where may not be set.
now the join can be or not be specified, this not needed in generateLowerBoundFilter function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there appears no way to specify criteria fields from join - ed tables, though the feature exists in the NS API. (maybe the formula field is for this but im not sure either)
This patch simply exposes the setting as an extra optional parameter 'join' to the Search request parameter 'search_filters', rather than it just always being set to null.