This repository has been archived by the owner on May 2, 2023. It is now read-only.
Search column sort fix #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sort boolean option for a search column appears to have never been created. It only ever sorts ASC by internalid regardless,This fixes that. Column can also be set ASC or DESC Descending: 'sort' = 'true' Ascending: 'sort' = 'false' Was not sure if to use string or bool , so went with string to fit in with the rest of the options. so 'true' works but true does not, this could be changed. If a column is set to sort, then the default internalid sort column is not added. With this patch multiple columns can be set to sort, though i have no idea if this works or not, compared with the readme stated action (which does not exist) to only sort by last column set to sort.
easy 'fix' to avoid problem of not being able to request limits on searches by internalId to make pages, when sorting by column other than internalId
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sort boolean option for a search column appears to have never been created. It only ever sorts ASC by internalid regardless,This fixes that.
Column can also be set ASC or DESC
Descending: 'sort' = 'true'
Ascending: 'sort' = 'false'
Was not sure if to use string or bool , so went with string to fit in with the rest of the options. so 'true' works but true does not, this could be changed.
If a column is set to sort, then the default internalid sort column is not added.