-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore old size calculation behaviour #1462
Restore old size calculation behaviour #1462
Conversation
@@ -705,15 +705,16 @@ nlohmann::json ExportQueryExecutionTrees::computeQueryResultAsQLeverJSON( | |||
j["runtimeInformation"]["meta"] = nlohmann::ordered_json( | |||
qet.getRootOperation()->getRuntimeInfoWholeQuery()); | |||
RuntimeInformation runtimeInformation = qet.getRootOperation()->runtimeInfo(); | |||
|
|||
size_t resultSize = runtimeInformation.numRows_; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important Note: For lazy results the "total count" with this change will mean absolutely nothing when the outermost operation doesn't support limits. In this case it will just mean how many rows there would've been if the last (and first with offset) block would've been sent too. So in the current code state this will never be higher than j["res"].size() + 2 * index block size
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1462 +/- ##
==========================================
+ Coverage 88.41% 89.45% +1.04%
==========================================
Files 362 366 +4
Lines 27426 34402 +6976
Branches 3705 4115 +410
==========================================
+ Hits 24248 30776 +6528
- Misses 1943 2397 +454
+ Partials 1235 1229 -6 ☔ View full report in Codecov by Sentry. |
fb39400
to
6fe92db
Compare
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
See #1455 for details