Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lazy join #1524

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
+1,192 −207

Skip undefined if guaranteed to be undefined

ac63c9c
Select commit
Loading
Failed to load commit list.
Open

Implement lazy join #1524

Skip undefined if guaranteed to be undefined
ac63c9c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 6, 2024 in 0s

87.79% (-0.40%) compared to 996315f

View this Pull Request on Codecov

87.79% (-0.40%) compared to 996315f

Details

Codecov Report

Attention: Patch coverage is 61.95373% with 148 lines in your changes missing coverage. Please review.

Project coverage is 87.79%. Comparing base (996315f) to head (ac63c9c).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/engine/Join.cpp 40.22% 91 Missing and 13 partials ⚠️
src/util/JoinAlgorithms/JoinAlgorithms.h 81.06% 3 Missing and 36 partials ⚠️
src/engine/AddCombinedRowToTable.h 0.00% 3 Missing ⚠️
src/index/IndexImpl.cpp 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
- Coverage   88.18%   87.79%   -0.40%     
==========================================
  Files         359      359              
  Lines       27061    27339     +278     
  Branches     3655     3702      +47     
==========================================
+ Hits        23865    24001     +136     
- Misses       1951     2051     +100     
- Partials     1245     1287      +42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov