Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ASK queries #1562

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Implement ASK queries #1562

wants to merge 10 commits into from

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Oct 17, 2024

No description provided.

Signed-off-by: Johannes Kalmbach <[email protected]>
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (4acbca3) to head (689a7e8).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1562      +/-   ##
==========================================
+ Coverage   88.47%   89.02%   +0.54%     
==========================================
  Files         363      368       +5     
  Lines       27533    33909    +6376     
  Branches     3714     3838     +124     
==========================================
+ Hits        24361    30188    +5827     
- Misses       1940     2472     +532     
- Partials     1232     1249      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
@hannahbast hannahbast changed the title Implement ASK queries. Implement ASK queries Oct 22, 2024
Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks a lot. Two comments:

  1. The else part of getResultForAsk is not yet covered by a test.
  2. One test still fails, hopefully not because of my minor revision

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all the tests pass, this is ready to merge. Thanks a lot!

PS: I don't thnk this needs any description beyond the title.

@sparql-conformance
Copy link

Conformance check passed ✅

Test Status Changes 📊

Number of Tests Previous Status Current Status
20 Failed Passed

Details: https://qlever.cs.uni-freiburg.de/sparql-conformance-ui?cur=689a7e828625724e26cd5b256e89c369fb411391&prev=aec57fe0f2026027cd8ef3f59b5d364ea7ad0474

Copy link

sonarcloud bot commented Oct 22, 2024

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some SonarCloud issues, which look like they should be addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants