-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ASK queries #1562
base: master
Are you sure you want to change the base?
Implement ASK queries #1562
Conversation
Signed-off-by: Johannes Kalmbach <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1562 +/- ##
==========================================
+ Coverage 88.47% 89.02% +0.54%
==========================================
Files 363 368 +5
Lines 27533 33909 +6376
Branches 3714 3838 +124
==========================================
+ Hits 24361 30188 +5827
- Misses 1940 2472 +532
- Partials 1232 1249 +17 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks a lot. Two comments:
- The
else
part ofgetResultForAsk
is not yet covered by a test. - One test still fails, hopefully not because of my minor revision
Signed-off-by: Johannes Kalmbach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all the tests pass, this is ready to merge. Thanks a lot!
PS: I don't thnk this needs any description beyond the title.
Conformance check passed ✅Test Status Changes 📊
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some SonarCloud issues, which look like they should be addressed
No description provided.