Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent memory allocation errors because of caching for lazy results #1578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Oct 22, 2024

Currently, when consuming a lazy result up to a point the code tries to prepare it for the cache. If during preparation we run out of memory this should not prevent the operation from running, it should just discard the value kept for the cache.

@sparql-conformance
Copy link

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.98%. Comparing base (aec57fe) to head (a4ece67).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1578   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files         368      368           
  Lines       33825    33864   +39     
  Branches     3827     3828    +1     
=======================================
+ Hits        30098    30135   +37     
  Misses       2473     2473           
- Partials     1254     1256    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant