-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement URLPattern #785
implement URLPattern #785
Conversation
89f46f0
to
02492e1
Compare
0ccd6d3
to
d2cd4f8
Compare
@anonrig Just to confirm... is this the spec? https://urlpattern.spec.whatwg.org |
Yes that's correct @lemire |
e51503f
to
524cb73
Compare
1a98cc9
to
18ef1a6
Compare
I don't particular mind, but please be aware that you are changing the coding convention. The C++ standard library uses all-lowercase with underscores names. You are using Camel case. If you merge this, it will mean that within the same library, we mix two conventions. |
380d57e
to
880e260
Compare
51690eb
to
010bc69
Compare
010bc69
to
a036101
Compare
Definitely on my todo!!!! |
Looking good so far. I think I'll need tests in place to properly evaluate everything go given the complexity. I want to be able to build and test locally with it before signing off. |
65c0406
to
61728b2
Compare
@jasnell This is ready to land. Would you be interested in writing the C API? |
This implements URLPattern from scratch. I'm adding
TODO: Optimization opportunity
notes in places I think an optimization can be done. The goal is to merge this once there is noTODO: Implement this
comments.TODOs
TODO: Implement this
occurrences (currently 4)url_pattern::match
Fixes #679