-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve set_port validation #839
fix: Improve set_port validation #839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the extra code right now and just focus on simplifying the code
Co-authored-by: Yagiz Nizipli <[email protected]>
Co-authored-by: Yagiz Nizipli <[email protected]>
Co-authored-by: Yagiz Nizipli <[email protected]>
Co-authored-by: Yagiz Nizipli <[email protected]>
Co-authored-by: Yagiz Nizipli <[email protected]>
thank you very much for the suggestions, I have accepted improvements that remove excess code, they have been instructive for me |
trimmed
string usingstd::find_if_not
anderase
."8080stuff"
or"8080/path"
would previously cause issues, now correctly handling them as"8080"
.Example:
"8080stuff"
→ Processed as:"8080"
"invalid80"
→ Processed as:""
(invalid)Fixes #826