Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve urlpattern::match() performance #879

Merged
merged 1 commit into from
Feb 15, 2025
Merged

improve urlpattern::match() performance #879

merged 1 commit into from
Feb 15, 2025

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 15, 2025

Improves the performance of both happy path and bad path, and reduces unnecessary string copies.

PS: We need benchmarks for URLPattern, but the change is not controversial.

@anonrig anonrig requested review from lemire and jasnell February 15, 2025 17:30
lemire
lemire approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it is likely a fine change.

@anonrig anonrig merged commit 0312be0 into main Feb 15, 2025
35 of 38 checks passed
@anonrig anonrig deleted the yagiz/improve-match-perf branch February 15, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anonrig @lemire