Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(infra-apps): nginx annotation in ingress examples #508

Merged
merged 1 commit into from
Jan 3, 2022
Merged

fix(infra-apps): nginx annotation in ingress examples #508

merged 1 commit into from
Jan 3, 2022

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Jan 3, 2022 •
edited
Loading

Description

Fixes the ingress annotation examples that i almost cargo-culted into the docs.

Issues

Checklist

  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • If I updated a dependency tool, or app, this PR contains a short summary of the changes I'm pulling
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 3, 2022
@hairmare hairmare marked this pull request as ready for review January 3, 2022 09:06
@hairmare hairmare requested a review from a team as a code owner January 3, 2022 09:06
@hairmare hairmare requested review from inisitijitty and vmaillot and removed request for a team January 3, 2022 09:06
inisitijitty
inisitijitty approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@inisitijitty inisitijitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hairmare hairmare merged commit 3e934f0 into adfinis:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inisitijitty inisitijitty inisitijitty approved these changes

@vmaillot vmaillot Awaiting requested review from vmaillot vmaillot was automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hairmare @inisitijitty