Garage week trace debug validators #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ngx.log(ngx.WARN, "Please initialize RequestTrackingManager before calling this method") | ||
| end | ||
|
|
||
| local tracingLogger = ngx.apiGateway.getAsyncLogger("api-gateway-debugging") |
There was a problem hiding this comment.
There's a few assumptions here we could think of configure rather than hard-coding:
- that there's an object
ngx.apiGateway. - that there's an object
ngx.apiGateway.getAsyncLogger - that there's a configuration for the logger named
api-gateway-debugging
There was a problem hiding this comment.
@ddragosd , let's then follow the same path as for the trackingManager variable and use
local tracingManager = ngx.apiGateway.tracing.manager
which should be initialized in the GW init code. WDYT?
The TracingManager object would need to have a method logTraceRequest which accepts a Lua table as a parameter.
…ts and bug fixes)
vdatcu
force-pushed
the
garage-week-trace-debug-validators
branch
from
8f18405
to
4f1db04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ddragosd ping