Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mcdan/param encrypt #10

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Mcdan/param encrypt #10

wants to merge 11 commits into from

Conversation

mcdan
Copy link

@mcdan mcdan commented Dec 16, 2019

Description

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-io
Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #10 into master will decrease coverage by 0.03%.
The diff coverage is 87.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   82.36%   82.33%   -0.04%     
==========================================
  Files         198      200       +2     
  Lines        9021     9277     +256     
  Branches      353      376      +23     
==========================================
+ Hits         7430     7638     +208     
- Misses       1591     1639      +48
Impacted Files Coverage Δ
...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala 100% <100%> (+3.22%) ⬆️
...rg/apache/openwhisk/core/entity/WhiskPackage.scala 96.66% <100%> (+0.05%) ⬆️
...nwhisk/core/monitoring/metrics/EventConsumer.scala 87.03% <100%> (-0.24%) ⬇️
...org/apache/openwhisk/core/entity/WhiskAction.scala 91.25% <100%> (ø) ⬆️
.../openwhisk/core/containerpool/ContainerProxy.scala 93.56% <100%> (+0.06%) ⬆️
.../scala/org/apache/openwhisk/core/WhiskConfig.scala 94.89% <100%> (+0.07%) ⬆️
...e/elasticsearch/ElasticSearchActivationStore.scala 83.64% <83.64%> (ø)
...a/org/apache/openwhisk/core/entity/Parameter.scala 88.77% <85.48%> (-1.8%) ⬇️
...he/openwhisk/core/entity/ParameterEncryption.scala 94.82% <94.82%> (ø)
...enwhisk/connector/kafka/KamonMetricsReporter.scala 76.19% <0%> (-23.81%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08efb58...aa0f85a. Read the comment docs.

@mcdan mcdan changed the base branch from master to RUNNER-2512 January 3, 2020 21:34
@mcdan mcdan changed the base branch from RUNNER-2512 to master January 3, 2020 21:34
Encrypt just before putting into the db
Decrypt only right before invoking the action
@mcdan mcdan force-pushed the mcdan/param-encrypt branch 3 times, most recently from 5c78b26 to 94ff4bd Compare January 9, 2020 21:09
Broke reading the kafka protocol into a new method to keep the
strict parsing of the scheme intact.
Use only base64 encoded keys.
@mcdan mcdan force-pushed the mcdan/param-encrypt branch 3 times, most recently from 60033b2 to 115cf1e Compare January 30, 2020 23:29
@mcdan mcdan force-pushed the mcdan/param-encrypt branch 3 times, most recently from a046bca to 071671a Compare February 3, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants