Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check to see if the user can see the topic before creating it, #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcdan
Copy link

@mcdan mcdan commented Jan 23, 2020

this allows lower privlage users to be set for the controller
and invoker.

Description

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

this allows lower privilege users to be set for the controller
and invoker.
@mcdan mcdan force-pushed the mcdan/topic-check-before-create branch from f407252 to 1875115 Compare January 23, 2020 19:56
@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #11 into master will increase coverage by 0.07%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   85.12%   85.19%   +0.07%     
==========================================
  Files         197      197              
  Lines        8839     8843       +4     
  Branches      619      606      -13     
==========================================
+ Hits         7524     7534      +10     
+ Misses       1315     1309       -6
Impacted Files Coverage Δ
...whisk/connector/kafka/KafkaMessagingProvider.scala 70.73% <42.85%> (+0.46%) ⬆️
...pache/openwhisk/core/invoker/InvokerReactive.scala 79.82% <0%> (-0.88%) ⬇️
...e/openwhisk/core/containerpool/ContainerPool.scala 96.17% <0%> (-0.64%) ⬇️
...che/openwhisk/core/database/CouchDbRestStore.scala 73.23% <0%> (-0.51%) ⬇️
.../org/apache/openwhisk/core/connector/Message.scala 77.96% <0%> (ø) ⬆️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 96.22% <0%> (+0.37%) ⬆️
...rg/apache/openwhisk/common/ForcibleSemaphore.scala 88.46% <0%> (+3.84%) ⬆️
...core/database/cosmosdb/RetryMetricsCollector.scala 85.71% <0%> (+4.76%) ⬆️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 100% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51de9d7...1875115. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants