Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesos support for NodeStats events #4

Open
wants to merge 142 commits into
base: ow-invoker-backpressure-mesos
Choose a base branch
from

Conversation

tysonnorris
Copy link

Description

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

dgrove-oss and others added 16 commits February 16, 2019 10:58
…pache#4294)

1. Fixed 2 typos that refer to non-existing response 'TooManyRequsts'
2. Updated description of PUT method for rule
3. Updated description of PUT method for trigger
4. Created new definition ActivationBrief
5. Changed response type for GET activations to refer to ActivationBrief instead of EntityBrief, which didn't match the actual response
6. Added attribute statusCode to definition ActivationBrief and Activation
7. Modified description of GET activations apache#2271
8. Added operationId to GET activation logs and result (apache#318)
9. Removed the init attribute from the ActionExec definition (apache#4201)
10. Use of 2 spaces for indentation, which is the default when working with the Swagger editor, instead of the four spaces used.
* Improve container factory documentation

Explicitly list some of the expectations and requirements an actual container factory / container implementation needs to satisfy. Addresses apache#4002.

* Address review feedback
…ryTests (apache#4305)

* Look up runtime tag for YARN tests

* Scala formatting
* Use custom manifest for YARN tests

* Remove imageTag method
…ily (apache#4299)

* wait for sentinel only in case no timeout occurred

* introduce timeout annotation

* nodejs:6 logging timeout action w/o busy loop

* do conversion from FiniteDuration to Duration
…pache#4275)

* Collect and log CosmosDB query metrics when extra logging is enabled Fixes apache#4268
If there is an deployment with several controllers, the test `Whisk rules should preserve rule status when a rule is updated` fails intermittently. The reason is, that there are several modifications on the rule. These modifications are already retried. But enabling and disabling the rule also modifies the database document. But that change is currently not retried.
This PR puts the enabling/disabling of the rule into the retry block as well to make this test more stable against our eventual consistency.

Co-authored-by: Somaya Jamil <[email protected]>
@codecov-io
Copy link

codecov-io commented Mar 2, 2019

Codecov Report

Merging #4 into ow-invoker-backpressure-mesos will decrease coverage by 36.22%.
The diff coverage is 21.05%.

Impacted file tree graph

@@                        Coverage Diff                         @@
##           ow-invoker-backpressure-mesos       #4       +/-   ##
==================================================================
- Coverage                          78.23%   42.01%   -36.23%     
==================================================================
  Files                                168      176        +8     
  Lines                               8152     8406      +254     
  Branches                             554      595       +41     
==================================================================
- Hits                                6378     3532     -2846     
- Misses                              1774     4874     +3100
Impacted Files Coverage Δ
...apache/openwhisk/core/entitlement/Collection.scala 85% <ø> (-2.5%) ⬇️
...penwhisk/core/containerpool/ContainerFactory.scala 85.71% <ø> (-3.18%) ⬇️
...he/openwhisk/core/invoker/NamespaceBlacklist.scala 100% <ø> (ø) ⬆️
...isk/core/controller/actions/PrimitiveActions.scala 27.89% <ø> (-57.83%) ⬇️
...pache/openwhisk/core/containerpool/Container.scala 69.62% <ø> (-13.93%) ⬇️
...sk/core/containerpool/docker/DockerContainer.scala 78.04% <ø> (-9.76%) ⬇️
...che/openwhisk/core/yarn/YARNContainerFactory.scala 0% <0%> (-87.5%) ⬇️
.../openwhisk/core/database/s3/CloudFrontSigner.scala 0% <0%> (ø)
.../apache/openwhisk/core/controller/WebActions.scala 6.85% <0%> (-82.99%) ⬇️
...che/openwhisk/core/loadBalancer/LeanBalancer.scala 0% <0%> (ø) ⬆️
... and 171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0617b5a...dc127ab. Read the comment docs.

somaya10 and others added 13 commits March 4, 2019 10:21
Records the clusterId (if configured) with the updated document while persisting in ComosDB. This is an optional property. By default no `clusterId` info is saved
* Update to CosmosDB SDK 2.4.2

* Remove logic related to storing attachments in CosmosDB

* Reduce throughput for test to 400
…ache#4284)

* Factor out some annotation names to WhiskAction singleton.

* Omit API key unless requested explicitly.

* Add an annotation provide-api-key which causes an API key to be passed to the action context.

* Modify Parameters.isTruthy to allow for caller to specify how it wants to treat a missing key.

Default is missing key -> false (preserving behavior).
Add test for isTruthy.

* Treat a missing provide-key-annotation as truthy annotation.

Actions that already exist without the annotation will receive the key as they might already expect.

* Add container proxy test.

* Update tests for new system annotation.

* Allow pre-existing actions to be exempt from new system annotations.

* Update docs.
* Kamon Gauge abstraction

* Switch to gauge metric
… with new format. (apache#4346)

* Adapts test harness to parses activation ids from wsk activation list with new format.
…4348)

Ignores the json records which have some of the required fields missing and replaces them with the error message from the parsing
…rceManager impls; handle ClusterResourceError in case of reaching cluster capacity
…dle containers; only remove idle containers that match the actual host/port of selected container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.