Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends TargetRequests with content and (meta)data callback #295

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jeffreydelooff
Copy link

@jeffreydelooff jeffreydelooff commented Nov 1, 2023

Exposes the native content with metadata callback to React Native. Currently it is not possible to retrieve the responseTokens or analytics payload as described for Android and for iOS.

Description

Added

  • a new TargetRequestObjectWithData which registers a callback containing both the content, data and error.
  • both native iOS and Android implementations to expose the contentWithDataCallback to RN

Related Issue

Exposes additional already existing native SDK functionality.

Motivation and Context

Currently it is not possible to retrieve any additional (meta)data from a TargetRequest.

How Has This Been Tested?

Added unit tests and tested this with assurance in an existing project.
Tracked the Target requests and its metadata. Added an analytics edge event to track this data.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jeffreydelooff jeffreydelooff changed the title Extend TargetRequests with content and (meta)data callback Extends TargetRequests with content and (meta)data callback Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant