Optimize build and deploy #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #811 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 56 56
Lines 3242 3243 +1
Branches 616 617 +1
=========================================
+ Hits 3242 3243 +1 ☔ View full report in Codecov by Sentry. |
moritzraho
approved these changes
Aug 23, 2024
MichaelGoberling
approved these changes
Aug 26, 2024
shazron
reviewed
Sep 23, 2024
| @@ -108,6 +108,9 @@ class Run extends BaseCommand { | |||
| } | |||
|
|
|||
| const verboseOutput = flags.verbose || flags.local || headlessApp | |||
| // we should evaluate this, a lot of output just disappears in the spinner text and | |||
| // using verbose dumps ALL of parcel's output, so this become unreadable | |||
| // we need a middle ground. -jm | |||
There was a problem hiding this comment.
perhaps log to file like the old --local run? search for OW_LOCAL_LOG_FILE
| @@ -91,6 +91,8 @@ function createChangeHandler (watcherOptions) { | |||
| try { | |||
| aioLogger.debug(`${filePath} has changed. Redeploying actions.`) | |||
| const filterActions = getActionNameFromPath(filePath, watcherOptions) | |||
| // this is happening, but its not showing up because verbose is usually off | |||
| // this might be more important and worthy of signalling to the user | |||
There was a problem hiding this comment.
I think this is important if we can define the importance of the "non-action file" is (more files are covered by your new changes) - the user might not know why their changes are not showing up otherwise
shazron
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the default for flag --force-build to false
RuntimeLib will include additional checks to not build actions it has already built, and not deploy actions already deployed. In order for users to see these benefits, the defaults are to use the optimized workflow and reduce time to build/deploy/run
If an action has changed, it will be built during app build/deploy/run
If an action has changed ( or action inputs including from $env or action descriptors ) it will be deployed during app deploy/run
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: