Add Envoy support for HTTP/1.0 health-check requests (#47)

Co-authored-by: Lucian Ilie <[email protected]>
adobe · Jul 12, 2022 · 1c1ec85 · 1c1ec85
1 parent b1251b9
commit 1c1ec85
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/controllers/tests/kafkacluster_controller_envoy_test.go b/controllers/tests/kafkacluster_controller_envoy_test.go
@@ -357,6 +357,8 @@ staticResources:
           - name: envoy.filters.http.router
             typedConfig:
               '@type': type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
+          httpProtocolOptions:
+            acceptHttp10: true
           routeConfig:
             name: local
             virtualHosts:
@@ -693,6 +695,8 @@ staticResources:
           - name: envoy.filters.http.router
             typedConfig:
               '@type': type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
+          httpProtocolOptions:
+            acceptHttp10: true
           routeConfig:
             name: local
             virtualHosts:
@@ -960,6 +964,8 @@ staticResources:
           - name: envoy.filters.http.router
             typedConfig:
               '@type': type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
+          httpProtocolOptions:
+            acceptHttp10: true
           routeConfig:
             name: local
             virtualHosts:
@@ -1280,6 +1286,8 @@ staticResources:
           - name: envoy.filters.http.router
             typedConfig:
               '@type': type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
+          httpProtocolOptions:
+            acceptHttp10: true
           routeConfig:
             name: local
             virtualHosts:
@@ -1600,6 +1608,8 @@ staticResources:
           - name: envoy.filters.http.router
             typedConfig:
               '@type': type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
+          httpProtocolOptions:
+            acceptHttp10: true
           routeConfig:
             name: local
             virtualHosts:

diff --git a/pkg/resources/envoy/configmap.go b/pkg/resources/envoy/configmap.go
@@ -128,6 +128,9 @@ func generateEnvoyHealthCheckListener(ingressConfig v1beta1.IngressConfig, log l
 	}
 
 	healthCheckFilter := &envoyhcm.HttpConnectionManager{
+		HttpProtocolOptions: &envoycore.Http1ProtocolOptions{
+			AcceptHttp_10: true,
+		},
 		StatPrefix: fmt.Sprintf("%s-healthcheck", envoyutils.AllBrokerEnvoyConfigName),
 		RouteSpecifier: &envoyhcm.HttpConnectionManager_RouteConfig{
 			RouteConfig: &envoyroute.RouteConfiguration{