Skip to content

Commit

Permalink
Enabled PDB for Envoy deployments ADDENDUM (#39)
Browse files Browse the repository at this point in the history
DisruptionBudget is declared as an inline field
so instead of composing the new struct, inherit it so it can be 
automatically read.

Currently you'd still need to declare:
```
podDisruptionBudget:
  PodDisruptionBudget:
    ...
  stragety:
```

for this to work while the CRD lists all the fields inlined
which is misleading for the user

Co-authored-by: Adi Muraru <[email protected]>
  • Loading branch information
alungu and amuraru authored Oct 21, 2021
1 parent 577d841 commit d178a43
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion api/v1beta1/kafkacluster_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ type DisruptionBudget struct {
// DisruptionBudgetWithStrategy defines the configuration for PodDisruptionBudget where the workload is managed by an external controller (eg. Deployments)
type DisruptionBudgetWithStrategy struct {
// PodDisruptionBudget default settings
DisruptionBudget DisruptionBudget `json:",inline"`
DisruptionBudget `json:",inline"`
// The strategy to be used, either minAvailable or maxUnavailable
// +kubebuilder:validation:Enum=minAvailable;maxUnavailable
Stategy string `json:"strategy,omitempty"`
Expand Down

0 comments on commit d178a43

Please sign in to comment.