-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chart animations to Area, Bar, Line, and (opacity-only) Scatter #224
base: byu-team-animations
Are you sure you want to change the base?
Commits on Feb 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ab5e3f7 - Browse repository at this point
Copy the full SHA ab5e3f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c421d9f - Browse repository at this point
Copy the full SHA c421d9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e09a53 - Browse repository at this point
Copy the full SHA 9e09a53View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8f65df - Browse repository at this point
Copy the full SHA b8f65dfView commit details -
feat: add timer value to signals (#127)
* chore: add timer value to signals * fix: remove debug from chart.story.tsx * chore: add tests for timer signal * fix: remove debug
Configuration menu - View commit details
-
Copy full SHA for 30a0af4 - Browse repository at this point
Copy the full SHA 30a0af4View commit details
Commits on Feb 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 84b075f - Browse repository at this point
Copy the full SHA 84b075fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20288a6 - Browse repository at this point
Copy the full SHA 20288a6View commit details
Commits on Feb 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 41d7141 - Browse repository at this point
Copy the full SHA 41d7141View commit details -
* chore: add timer value to signals * fix: remove debug from chart.story.tsx * chore: add tests for timer signal * fix: remove debug * feat: add previous data table to data * fix: fix broken test * fix: remove debug
Configuration menu - View commit details
-
Copy full SHA for 3b09115 - Browse repository at this point
Copy the full SHA 3b09115View commit details
Commits on Feb 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c8fc4df - Browse repository at this point
Copy the full SHA c8fc4dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bcd803 - Browse repository at this point
Copy the full SHA 3bcd803View commit details
Commits on Feb 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4876f79 - Browse repository at this point
Copy the full SHA 4876f79View commit details
Commits on Feb 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b4405e3 - Browse repository at this point
Copy the full SHA b4405e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d36b674 - Browse repository at this point
Copy the full SHA d36b674View commit details -
Configuration menu - View commit details
-
Copy full SHA for df8c5fb - Browse repository at this point
Copy the full SHA df8c5fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1fc3d7 - Browse repository at this point
Copy the full SHA c1fc3d7View commit details
Commits on Feb 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a7897f1 - Browse repository at this point
Copy the full SHA a7897f1View commit details
Commits on Feb 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c349cd5 - Browse repository at this point
Copy the full SHA c349cd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 496e62f - Browse repository at this point
Copy the full SHA 496e62fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 248d2d2 - Browse repository at this point
Copy the full SHA 248d2d2View commit details
Commits on Feb 29, 2024
-
Animations add dodged bar-specific animations as well as hide labels …
…until animations finished
Configuration menu - View commit details
-
Copy full SHA for 43a29ff - Browse repository at this point
Copy the full SHA 43a29ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for d96361f - Browse repository at this point
Copy the full SHA d96361fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e736d42 - Browse repository at this point
Copy the full SHA e736d42View commit details
Commits on Mar 1, 2024
-
Merge pull request #153 from adobe/nathaniel-judd/byu-team/animations
Nathaniel judd/byu team/animations
Configuration menu - View commit details
-
Copy full SHA for a3c56d9 - Browse repository at this point
Copy the full SHA a3c56d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00ec648 - Browse repository at this point
Copy the full SHA 00ec648View commit details -
Merge pull request #160 from adobe/jacob-hart/byu-team/easing
Add animation easing
Configuration menu - View commit details
-
Copy full SHA for e7bcc86 - Browse repository at this point
Copy the full SHA e7bcc86View commit details -
Configuration menu - View commit details
-
Copy full SHA for af1a1e6 - Browse repository at this point
Copy the full SHA af1a1e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56b39a5 - Browse repository at this point
Copy the full SHA 56b39a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6159cad - Browse repository at this point
Copy the full SHA 6159cadView commit details -
Animations added extra check for animating between datasets that they…
… aren't exactly equal
Configuration menu - View commit details
-
Copy full SHA for 644ec12 - Browse repository at this point
Copy the full SHA 644ec12View commit details
Commits on Mar 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 53c2c06 - Browse repository at this point
Copy the full SHA 53c2c06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 560d4e1 - Browse repository at this point
Copy the full SHA 560d4e1View commit details
Commits on Mar 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7702d7a - Browse repository at this point
Copy the full SHA 7702d7aView commit details -
Merge branch 'animations' of github.com:adobe/react-spectrum-charts i…
…nto gtonkinson/animations
Configuration menu - View commit details
-
Copy full SHA for 18bba7a - Browse repository at this point
Copy the full SHA 18bba7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb885e6 - Browse repository at this point
Copy the full SHA fb885e6View commit details
Commits on Mar 8, 2024
-
Add animation spec backwards compatibility with existing tests (#169)
* Remove console.warn * Fix areaUtil tests * Fix areaSpecBuilder tests * Update linePointUtils to avoid creating unnecessary keys * Fix lineMarkUtils tests * Fix lineSpecBuilder tests * Fix bar tests * Fix metricRangeUtils tests
Configuration menu - View commit details
-
Copy full SHA for 4b849ed - Browse repository at this point
Copy the full SHA 4b849edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 956e421 - Browse repository at this point
Copy the full SHA 956e421View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8174613 - Browse repository at this point
Copy the full SHA 8174613View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cc4c2a - Browse repository at this point
Copy the full SHA 5cc4c2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9832018 - Browse repository at this point
Copy the full SHA 9832018View commit details -
Configuration menu - View commit details
-
Copy full SHA for e56701b - Browse repository at this point
Copy the full SHA e56701bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7cc0a1 - Browse repository at this point
Copy the full SHA c7cc0a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83bad13 - Browse repository at this point
Copy the full SHA 83bad13View commit details -
Configuration menu - View commit details
-
Copy full SHA for abe7efd - Browse repository at this point
Copy the full SHA abe7efdView commit details
Commits on Mar 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 14285ba - Browse repository at this point
Copy the full SHA 14285baView commit details -
Configuration menu - View commit details
-
Copy full SHA for acb855e - Browse repository at this point
Copy the full SHA acb855eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1aa7490 - Browse repository at this point
Copy the full SHA 1aa7490View commit details
Commits on Mar 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9329ade - Browse repository at this point
Copy the full SHA 9329adeView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbea9a1 - Browse repository at this point
Copy the full SHA cbea9a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bf86f8 - Browse repository at this point
Copy the full SHA 2bf86f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fca769 - Browse repository at this point
Copy the full SHA 0fca769View commit details
Commits on Mar 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5c53a88 - Browse repository at this point
Copy the full SHA 5c53a88View commit details
Commits on Mar 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8905b7e - Browse repository at this point
Copy the full SHA 8905b7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7174ba9 - Browse repository at this point
Copy the full SHA 7174ba9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 628ee82 - Browse repository at this point
Copy the full SHA 628ee82View commit details -
Animations added interface to allow certain tests to override animati…
…ons property in trellisbar. A similar approach can be used in other tests
Configuration menu - View commit details
-
Copy full SHA for 151cbe2 - Browse repository at this point
Copy the full SHA 151cbe2View commit details
Commits on Mar 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b7bcc62 - Browse repository at this point
Copy the full SHA b7bcc62View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2f9e66 - Browse repository at this point
Copy the full SHA a2f9e66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c7c546 - Browse repository at this point
Copy the full SHA 1c7c546View commit details
Commits on Mar 20, 2024
-
Animations useState var for spec, when popoverIsOpen set spec to no a…
…nimations version
Configuration menu - View commit details
-
Copy full SHA for 42ece8e - Browse repository at this point
Copy the full SHA 42ece8eView commit details
Commits on Mar 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e785232 - Browse repository at this point
Copy the full SHA e785232View commit details
Commits on Mar 24, 2024
-
Change animation duration (#198)
Change animation duration and use constants instead of magic numbers
Configuration menu - View commit details
-
Copy full SHA for 6aa151e - Browse repository at this point
Copy the full SHA 6aa151eView commit details
Commits on Mar 27, 2024
-
njudd/animations added animateFromZero state variable to RscChart and…
… implemented it across specbuilders, set it to false when chart popover is changed and set to false
Configuration menu - View commit details
-
Copy full SHA for b6a0b91 - Browse repository at this point
Copy the full SHA b6a0b91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23345a7 - Browse repository at this point
Copy the full SHA 23345a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa2e00c - Browse repository at this point
Copy the full SHA aa2e00cView commit details
Commits on Mar 29, 2024
-
Merge pull request #207 from adobe/njudd/byu-team/animations
Njudd/byu team/animations - fixes to animation function when popover pressed, fixing trellis bar and other tests broken by animations
Configuration menu - View commit details
-
Copy full SHA for e217127 - Browse repository at this point
Copy the full SHA e217127View commit details
Commits on Apr 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fc12bef - Browse repository at this point
Copy the full SHA fc12befView commit details -
Animations made area and line charts have tooltips and highlight mark…
…s hidden until animations are done
Configuration menu - View commit details
-
Copy full SHA for c3ee2b8 - Browse repository at this point
Copy the full SHA c3ee2b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78d712a - Browse repository at this point
Copy the full SHA 78d712aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 46b5251 - Browse repository at this point
Copy the full SHA 46b5251View commit details
Commits on Apr 3, 2024
-
Animations made area and line charts have tooltips and highlight mark… (
#213) Animations made area and line charts have tooltips and highlight marks hidden until animations are done
Configuration menu - View commit details
-
Copy full SHA for 44cac56 - Browse repository at this point
Copy the full SHA 44cac56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05d1de3 - Browse repository at this point
Copy the full SHA 05d1de3View commit details -
Add Opacity animation functionality to line, bar, scatter, trendline,…
… legends, and area charts (#223)
Configuration menu - View commit details
-
Copy full SHA for f15f413 - Browse repository at this point
Copy the full SHA f15f413View commit details
Commits on Apr 4, 2024
-
* Add signals and scales for opacity animations These changes add signals and scales for opcity animations for the barSpecBuilder. As part of these changes, lengendSpecBuilder was also changed to update an existing signal. * Remove console.warn * Fix areaUtil tests * Fix areaSpecBuilder tests * Update linePointUtils to avoid creating unnecessary keys * Fix lineMarkUtils tests * Fix lineSpecBuilder tests * Fix bar tests * Fix metricRangeUtils tests * Add opacity animations to all bar charts This change allows for opacity animations to all bar charts with a tooltip or a popover. Animations must be enabled on the chart level for the animations to appear. * Refactor code to match style of existing code * Add opacity animation functionality to line charts. With this change, all line charts with a tooltip or popover will animate on hover. Visiually, the animation eases the opacity in and out on non-hovered lines. * Add opacity animations to area and trendline. With these changes, and upon animation enablement, opacity animations are present with an area, line, and bar chart that has a tooltip, popover, or trendline. * Refactor mouseover function to reduce code for opacity animations * Add opacity animations to legend symbols. This change includes logic that adds opacity animation to legend symbols if the current spec has the opacity animation signals for line, bar, or area charts. This change also has a couple added checks for interactive children. * Integrate opacity animations with new changes on main * Remove unecessary debug settings * Fix legend hover opacity animations * Add TODO comments for tracking and testing purposes * Change opacity animation default * Change opacity animation gates to expressly check for false * chore: upgrade storybook to v8 * fix: add testing for animations * testing for opacity * fix: add testing for opacity, still need to add opacity story * fix: add testing to test opacity * fix opacity stories * remove readded code * fix odd indenting * remove unused def' --------- Co-authored-by: Adam <[email protected]> Co-authored-by: Jacob <[email protected]> Co-authored-by: Marshall Peterson <[email protected]> Co-authored-by: tanugarg04 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7fdca27 - Browse repository at this point
Copy the full SHA 7fdca27View commit details
Commits on Apr 5, 2024
-
Animations-3 fixed issues with stacked bars and stacked areas - added…
… stacked area story to Animations
Configuration menu - View commit details
-
Copy full SHA for 2a9de92 - Browse repository at this point
Copy the full SHA 2a9de92View commit details -
Configuration menu - View commit details
-
Copy full SHA for b68afae - Browse repository at this point
Copy the full SHA b68afaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04128b1 - Browse repository at this point
Copy the full SHA 04128b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b75a2b - Browse repository at this point
Copy the full SHA 2b75a2bView commit details -
Merge pull request #228 from adobe/njudd/byu-team/animations-3
Njudd/byu team/animations 3
Configuration menu - View commit details
-
Copy full SHA for f001052 - Browse repository at this point
Copy the full SHA f001052View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fc39fa - Browse repository at this point
Copy the full SHA 7fc39faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03c4ebe - Browse repository at this point
Copy the full SHA 03c4ebeView commit details
Commits on Apr 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d34b64c - Browse repository at this point
Copy the full SHA d34b64cView commit details
Commits on Apr 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f255a21 - Browse repository at this point
Copy the full SHA f255a21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aa58af - Browse repository at this point
Copy the full SHA 5aa58afView commit details
Commits on Apr 10, 2024
-
Animations made ANIMATION_FUNCTION constant that is assigned to EASE_…
…OUT to reduce code ripples when we want to change it
Configuration menu - View commit details
-
Copy full SHA for ce160d5 - Browse repository at this point
Copy the full SHA ce160d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52e5826 - Browse repository at this point
Copy the full SHA 52e5826View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6a7f1c - Browse repository at this point
Copy the full SHA f6a7f1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1ac8ba - Browse repository at this point
Copy the full SHA b1ac8baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c9cb9a - Browse repository at this point
Copy the full SHA 6c9cb9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 67a5778 - Browse repository at this point
Copy the full SHA 67a5778View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57a120f - Browse repository at this point
Copy the full SHA 57a120fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97c8c6b - Browse repository at this point
Copy the full SHA 97c8c6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7365302 - Browse repository at this point
Copy the full SHA 7365302View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7927719 - Browse repository at this point
Copy the full SHA 7927719View commit details -
Animatioins moved usePreviousChartData out to the react hooks directo…
…ry - removed generics in favor of ChartData[]
Configuration menu - View commit details
-
Copy full SHA for f87e38c - Browse repository at this point
Copy the full SHA f87e38cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 579dcf9 - Browse repository at this point
Copy the full SHA 579dcf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for dabe3e9 - Browse repository at this point
Copy the full SHA dabe3e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2923b15 - Browse repository at this point
Copy the full SHA 2923b15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31dc879 - Browse repository at this point
Copy the full SHA 31dc879View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51e4b18 - Browse repository at this point
Copy the full SHA 51e4b18View commit details
Commits on Apr 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1a64554 - Browse repository at this point
Copy the full SHA 1a64554View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bd61d6 - Browse repository at this point
Copy the full SHA 3bd61d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2e20e3 - Browse repository at this point
Copy the full SHA c2e20e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1488446 - Browse repository at this point
Copy the full SHA 1488446View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5e9caf - Browse repository at this point
Copy the full SHA a5e9cafView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1bebf4 - Browse repository at this point
Copy the full SHA a1bebf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ede3c17 - Browse repository at this point
Copy the full SHA ede3c17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d82e8f - Browse repository at this point
Copy the full SHA 0d82e8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc9273f - Browse repository at this point
Copy the full SHA fc9273fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2771e35 - Browse repository at this point
Copy the full SHA 2771e35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f7e3a8 - Browse repository at this point
Copy the full SHA 2f7e3a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc1ce4c - Browse repository at this point
Copy the full SHA fc1ce4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for af6f684 - Browse repository at this point
Copy the full SHA af6f684View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6546d0c - Browse repository at this point
Copy the full SHA 6546d0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1b32db - Browse repository at this point
Copy the full SHA a1b32dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for f695e8c - Browse repository at this point
Copy the full SHA f695e8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00b1d03 - Browse repository at this point
Copy the full SHA 00b1d03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 573305b - Browse repository at this point
Copy the full SHA 573305bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05db649 - Browse repository at this point
Copy the full SHA 05db649View commit details -
Animation set SharedChartProps animations to optional, added necessar…
…y check to rscChart (even though it will always be defined by that point)
Configuration menu - View commit details
-
Copy full SHA for d9aa043 - Browse repository at this point
Copy the full SHA d9aa043View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39b7a41 - Browse repository at this point
Copy the full SHA 39b7a41View commit details