Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed manifest task #156

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fixed manifest task #156

merged 1 commit into from
Jul 10, 2023

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Jul 10, 2023

Description

Building the manifest file would create a file missing the trailing blank space, which must be run through prettier to be fixed. I fixed the buildManifest task to run the file contents through prettier before writing the file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Task update

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023

⚠️ No Changeset found

Latest commit: 98584f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GarthDB
Copy link
Member Author

GarthDB commented Jul 10, 2023

Run report for eee00779

Total time: 50.1s | Comparison time: 47.7s | Estimated loss: 2.3s (4.7% slower)

Action Time Status Info
🟩 SetupNodeTool(18.13.0) 3.4s Passed
🟩 InstallNodeDeps(18.13.0) 18.8s Passed
🟩 SyncNodeProject(tokens) 0.9ms Passed
🟩 SyncNodeProject(site) 0.2ms Passed
🟩 RunTarget(tokens:build) 22.7s Passed
🟩 SyncNodeProject(visualizer) 21ms Passed
🟩 SyncWorkspace 0ms Passed
🟩 RunTarget(tokens:test) 2s Passed
🟩 RunTarget(site:noop) 12.4ms Passed
🟩 RunTarget(tokens:noop) 2s Passed
🟩 RunTarget(tokens:buildManifest) 183.3ms Passed
🟩 RunTarget(tokens:generateDiffResult) 3.2s Passed
🟩 RunTarget(visualizer:noop) 13.2ms Passed
Touched files
package.json
packages/tokens/tasks/buildManifest.js
pnpm-lock.yaml

@GarthDB GarthDB merged commit 4ec09da into main Jul 10, 2023
2 checks passed
@GarthDB GarthDB deleted the prettier branch July 10, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant