Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed meter-default-width to meter-width #182

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Aug 23, 2023

Description

Renamed meter-default-width to meter-width

Related Issue

DNA-1297

Motivation and Context

We try to avoid "default" in the name (unless it's the state) because it's a word that implies that it's relative to something else that may not be named, which could get confusing. So meter-width I think for the name, and then just add a note in the specs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023

🦋 Changeset detected

Latest commit: 4e8c4d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adobe/spectrum-tokens Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GarthDB GarthDB changed the title feat(tokens): renamed meter-default-width to meter-width, closes DNA-… Renamed meter-default-width to meter-width Aug 23, 2023
@GarthDB
Copy link
Member Author

GarthDB commented Aug 23, 2023

Run report for e9f16a82

Total time: 59s | Comparison time: 56.3s | Estimated loss: 2.7s (4.6% slower)

Action Time Status Info
⬛️ SetupNodeTool(18.13.0) 347.5ms Skipped
🟩 InstallNodeDeps(18.13.0) 25.8s Passed
🟩 SyncNodeProject(tokens) 5.8ms Passed
🟩 RunTarget(tokens:build) 27.8s Passed
🟩 SyncWorkspace 0ms Passed
🟩 RunTarget(tokens:buildManifest) 289.1ms Passed
🟩 RunTarget(tokens:test) 2.6s Passed
🟩 RunTarget(tokens:generateDiffResult) 4.7s Passed
Touched files
.changeset/strong-tables-cheer.md
packages/tokens/src/layout-component.json

@GarthDB GarthDB merged commit bb89361 into main Aug 23, 2023
3 checks passed
@GarthDB GarthDB deleted the garthdb/DNA-1297-meter-width branch August 23, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant