Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing wireframe values #184

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Missing wireframe values #184

merged 1 commit into from
Sep 7, 2023

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Sep 7, 2023

Description

Added wireframe values to 2 color tokens.

Tokens update (2):

  • opacity-checkerboard-square-dark
  • overlay-opacity

Motivation and Context

Running some tests, I found 2 color tokens were missing wireframe values in the sets.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 21990da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adobe/spectrum-tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GarthDB
Copy link
Member Author

GarthDB commented Sep 7, 2023

Run report for c2bcfcb2

Total time: 55.2s | Comparison time: 52.4s | Estimated loss: 2.9s (5.2% slower)

Action Time Status Info
🟩 SetupNodeTool(18.13.0) 4.5s Passed
🟩 InstallNodeDeps(18.13.0) 19.2s Passed
🟩 SyncNodeProject(tokens) 0.2ms Passed
🟩 RunTarget(tokens:build) 24.2s Passed
🟩 SyncWorkspace 0ms Passed
🟩 RunTarget(tokens:buildManifest) 208.8ms Passed
🟩 RunTarget(tokens:test) 2.2s Passed
🟩 RunTarget(tokens:generateDiffResult) 7.2s Passed
Touched files
.changeset/olive-feet-fetch.md
packages/tokens/src/color-aliases.json
packages/tokens/src/color-component.json

@GarthDB GarthDB merged commit 6f5443e into main Sep 7, 2023
3 checks passed
@GarthDB GarthDB deleted the garthdb/missing-wireframe-values branch September 7, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant