Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started on creating the CLI for the diff generator #356

Merged
merged 47 commits into from
Jul 9, 2024

Conversation

shirlsli
Copy link
Collaborator

Description

Using commander and chalk libraries to create a CLI for the diff generator in the same package as the diff generator library.

Motivation and Context

We want to be able to see the results of the token diff generator in an easy-to-read format within the terminal.

How Has This Been Tested?

It hasn't been tested, but will eventually be!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

changeset-bot bot commented Jun 11, 2024

⚠️ No Changeset found

Latest commit: a4e6e82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GarthDB
Copy link
Member

GarthDB commented Jun 11, 2024

Run report for a4e6e827

Total time: 32.1s | Comparison time: 36.5s | Estimated savings: 4.5s (12.2% faster)

Action Time Status Info
🟩 SyncWorkspace 0ms Passed
⬛️ SetupToolchain(node:~20.12) 1.7s Skipped
🟩 InstallWorkspaceDeps(node:~20.12) 9.3s Passed
🟩 SyncProject(node, diff) 0.2ms Passed
🟩 SyncProject(node, root) 0.3ms Passed
🟩 SyncProject(node, tokens) 0.3ms Passed
🟩 RunTask(diff:diff) 125.9ms Passed
🟩 RunTask(diff:test) 5s Passed
🟩 RunTask(root:test) 1.7s Passed
🟩 RunTask(tokens:buildTokens) 18s Passed
🟩 RunTask(tokens:buildManifest) 206.7ms Passed
🟩 RunTask(tokens:generateDiffResult) 2s Passed
🟩 RunTask(tokens:test) 3s Passed
🟩 RunTask(tokens:build) 6.9ms Passed
Touched files
packages/tokens/test/snapshots/deprecateExpress.test.js.md
packages/tokens/test/snapshots/deprecateExpress.test.js.snap
pnpm-lock.yaml
tools/diff-generator/package-lock.json
tools/diff-generator/package.json
tools/diff-generator/src/lib/added-token-detection.js
tools/diff-generator/src/lib/cli.js
tools/diff-generator/src/lib/deleted-token-detection.js
tools/diff-generator/src/lib/deprecated-token-detection.js
tools/diff-generator/src/lib/file-import.js
tools/diff-generator/src/lib/index.js
tools/diff-generator/src/lib/updated-token-detection.js
tools/diff-generator/test/addedToken.test.js
tools/diff-generator/test/cli.test.js
tools/diff-generator/test/fileImport.test.js
tools/diff-generator/test/snapshots/cli.test.js.md
tools/diff-generator/test/snapshots/cli.test.js.snap
tools/diff-generator/test/snapshots/file-import.test.js.md
tools/diff-generator/test/snapshots/file-import.test.js.snap
tools/diff-generator/test/snapshots/fileImport.test.js.md
tools/diff-generator/test/snapshots/fileImport.test.js.snap
tools/diff-generator/test/test-cli-outputs/expected-added-property.txt
tools/diff-generator/test/test-cli-outputs/expected-all-tokens.txt
tools/diff-generator/test/test-cli-outputs/expected-branch-release-compare.txt
tools/diff-generator/test/test-cli-outputs/expected-branches-added.txt
tools/diff-generator/test/test-cli-outputs/expected-branches-changes.txt
tools/diff-generator/test/test-cli-outputs/expected-branches-deleted.txt
tools/diff-generator/test/test-cli-outputs/expected-deleted-property-token.txt
tools/diff-generator/test/test-cli-outputs/expected-deleted-property.txt
tools/diff-generator/test/test-cli-outputs/expected-main-branch.txt
tools/diff-generator/test/test-cli-outputs/expected-non-schema-property.txt
tools/diff-generator/test/test-cli-outputs/expected-release-branch-compare.txt
tools/diff-generator/test/test-cli-outputs/expected-renamed-added-deleted-deprecated.txt
tools/diff-generator/test/test-cli-outputs/expected-renamed-added-deleted.txt
tools/diff-generator/test/test-cli-outputs/expected-renamed-property-token.txt
tools/diff-generator/test/test-schemas/added-deleted-set-token-property.json
tools/diff-generator/test/test-schemas/added-inner-value-token.json
tools/diff-generator/test/test-schemas/added-non-schema-property-token.json
tools/diff-generator/test/test-schemas/added-property-set-token.json
tools/diff-generator/test/test-schemas/basic-set-token-property.json
tools/diff-generator/test/test-schemas/renamed-added-deleted-property-set-token.json
tools/diff-generator/test/tokenDiff.test.js
tools/diff-generator/test/updatedToken.test.js

@shirlsli shirlsli requested a review from GarthDB June 13, 2024 23:04
@shirlsli shirlsli marked this pull request as ready for review June 13, 2024 23:04
@shirlsli shirlsli changed the base branch from main to diff-generator June 13, 2024 23:04
Shirley Li and others added 22 commits June 18, 2024 15:16
@shirlsli shirlsli merged commit a4e6e82 into diff-generator Jul 9, 2024
4 checks passed
@shirlsli shirlsli deleted the shirlsli/diff-generator-cli branch July 9, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants