Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed and tested cli output for comparing tokens from a release and branch #366

Merged

Conversation

shirlsli
Copy link
Collaborator

Description

Changed how I printed out the cli version and branch names in the report.

Motivation and Context

The functionality for comparing release tokens with branch tokens and vice versa (due to how I did the file importing) was already there; however, the way I coded the cli output displayed the version and branch names as one or the other. This was because I wasn't sure if that was something we wanted before merging the previous PR, but now this PR will change it so you can compare between releases and branches.

How Has This Been Tested?

  • Added snapshot tests to file import test file to check comparison between branch tokens and release tokens (and vice versa)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

changeset-bot bot commented Jun 27, 2024

⚠️ No Changeset found

Latest commit: ad8ee39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GarthDB
Copy link
Member

GarthDB commented Jun 27, 2024

Run report for ad8ee39d

Total time: 15s | Comparison time: 15.8s | Estimated savings: 795.8ms (5.0% faster)

Action Time Status Info
🟩 SyncWorkspace 0ms Passed
⬛️ SetupToolchain(node:~20.12) 1.6s Skipped
🟩 InstallWorkspaceDeps(node:~20.12) 9.1s Passed
🟩 SyncProject(node, diff) 0.2ms Passed
🟩 SyncProject(node, root) 0.2ms Passed
🟩 RunTask(diff:diff) 98ms Passed
🟩 RunTask(diff:test) 4.3s Passed
🟩 RunTask(root:test) 1.6s Passed
Touched files
tools/diff-generator/src/lib/cli.js
tools/diff-generator/src/lib/index.js
tools/diff-generator/src/lib/updated-token-detection.js
tools/diff-generator/test/cli.test.js
tools/diff-generator/test/fileImport.test.js
tools/diff-generator/test/snapshots/cli.test.js.md
tools/diff-generator/test/snapshots/cli.test.js.snap
tools/diff-generator/test/snapshots/fileImport.test.js.md
tools/diff-generator/test/snapshots/fileImport.test.js.snap
tools/diff-generator/test/test-cli-outputs/expected-branch-release-compare.txt
tools/diff-generator/test/test-cli-outputs/expected-release-branch-compare.txt
tools/diff-generator/test/test-cli-outputs/expected-renamed-property-token.txt
tools/diff-generator/test/test-schemas/renamed-added-deleted-property-set-token.json
tools/diff-generator/test/tokenDiff.test.js
tools/diff-generator/test/updatedToken.test.js

@shirlsli shirlsli marked this pull request as ready for review June 27, 2024 22:56
@shirlsli shirlsli requested a review from GarthDB June 27, 2024 22:56
@GarthDB GarthDB merged commit ad8ee39 into shirlsli/diff-generator-cli Jul 8, 2024
4 checks passed
@GarthDB GarthDB deleted the shirlsli/diff-generator-refactor branch July 8, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants