Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented sharing via link for diff generator website #386

Conversation

shirlsli
Copy link
Collaborator

Description

The sharing via link function has been added to the diff generator website.

Motivation and Context

We want people to be able to share what diff combinations they are making to others in a convenient way.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: 901c303

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GarthDB
Copy link
Member

GarthDB commented Jul 29, 2024

Run report for 901c3036

Total time: 14.4s | Comparison time: 15.4s | Estimated savings: 967ms (6.3% faster)

Action Time Status Info
🟩 SyncWorkspace 4.8ms Passed
⬛️ SetupToolchain(node:~20.12) 2.3s Skipped
🟩 SyncProject(node, diff) 0.5ms Passed
🟩 SyncProject(node, root) 0.5ms Passed
🟩 SyncProject(node, tdiff) 0.2ms Passed
🟩 InstallWorkspaceDeps(node:~20.12) 10.4s Passed
🟩 RunTask(root:test) 1.4s Passed
🟥 RunTask(tdiff:typescript) 1.7s Failed
⬛️ RunTask(tdiff:build) 0.1ms Skipped
Touched files
docs/token-diff/src/CompareCard.ts
docs/token-diff/src/DiffReport.ts
docs/token-diff/src/PageContainer.ts
docs/token-diff/src/TokenDiff.ts

@shirlsli shirlsli closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants