Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated S2 Table tokens #405

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Conversation

mrcjhicks
Copy link
Collaborator

@mrcjhicks mrcjhicks commented Aug 22, 2024

Created by Action: https://github.com/adobe/spectrum-tokens-studio-data/actions/runs/10511818984
Tokens Studio PR: adobe/spectrum-tokens-studio-data#161

Description

Updated tokens for the S2 Table component in S2 layout.component set.

table-column-header-row-top-to-text-medium
table-row-top-to-text-medium-regular
table-row-bottom-to-text-medium-regular
table-row-top-to-text-medium-spacious
table-header-row-checkbox-to-top-medium
table-row-checkbox-to-top-medium-compact
table-row-checkbox-to-top-medium-regular
table-row-checkbox-to-top-medium-spacious
Added new token to the S2 layout set:

side-focus-indicator
Tokens changes are reflected in both desktop and mobile sets.

Motivation and context

Table component is being formalized as a Spectrum 2 component. These updated tokens define the design data needed for implementation.

Copy link

changeset-bot bot commented Aug 22, 2024

⚠️ No Changeset found

Latest commit: bf61491

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GarthDB
Copy link
Member

GarthDB commented Aug 22, 2024

Run report for 3eda5ddc

Total time: 52.4s | Comparison time: 1m 8s | Estimated savings: 16.5s (24.0% faster)

Action Time Status Info
🟩 SyncWorkspace 5.8ms Passed
⬛️ SetupToolchain(node:~20.12) 1.5s Skipped
🟩 SyncProject(node, root) 0.3ms Passed
🟩 SyncProject(node, site) 0.4ms Passed
🟩 SyncProject(node, tokens) 0.4ms Passed
🟩 RunTask(site:copySchema) 44ms Passed
🟩 InstallWorkspaceDeps(node:~20.12) 8.2s Passed
🟩 RunTask(tokens:buildManifest) 285.4ms Passed
🟩 RunTask(root:test) 1.7s Passed
🟩 RunTask(site:build) 21.6s Passed
🟩 RunTask(tokens:buildTokens) 29.9s Passed
🟩 RunTask(tokens:build) 14.7ms Passed
🟩 RunTask(tokens:test) 3.3s Passed
🟩 RunTask(tokens:generateDiffResult) 12.8s Passed
Touched files
.changeset/tender-monkeys-flash.md
packages/tokens/schemas/token-types/gradient-stop.json
packages/tokens/src/color-aliases.json
packages/tokens/src/color-component.json
packages/tokens/src/color-palette.json
packages/tokens/src/layout-component.json
packages/tokens/src/layout.json
packages/tokens/src/semantic-color-palette.json
pnpm-lock.yaml

@GarthDB GarthDB changed the title feat: updates from spectrum-tokens-studio-data Updated S2 Table tokens Aug 22, 2024
@GarthDB GarthDB marked this pull request as ready for review October 3, 2024 21:08
@GarthDB GarthDB merged commit b60f517 into beta Oct 3, 2024
4 checks passed
@GarthDB GarthDB deleted the tokens-sync/patch-spectrum2-from-main branch October 3, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants