Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed test option to local #407

Merged
merged 45 commits into from
Aug 29, 2024
Merged

Changed test option to local #407

merged 45 commits into from
Aug 29, 2024

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Aug 29, 2024

Duplicate of #398 - this version removes the diff web app that doesn't function as a static web app without authentication.

Description

Changed test command to local.

Motivation and Context

Wanted cli to be able to compare all token files in local without typing out all the names.

How Has This Been Tested?

Need to revise tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Shirley Li and others added 30 commits July 9, 2024 11:48
Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: c186fb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adobe/token-diff-generator Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GarthDB
Copy link
Member Author

GarthDB commented Aug 29, 2024

Run report for c186fb8e

Total time: 13.9s | Comparison time: 14.6s | Estimated savings: 692ms (4.7% faster)

Action Time Status Info
🟩 SyncWorkspace 4.8ms Passed
⬛️ SetupToolchain(node:~20.12) 1.3s Skipped
🟩 SyncProject(node, diff) 0.7ms Passed
🟩 SyncProject(node, root) 0.7ms Passed
🟩 InstallWorkspaceDeps(node:~20.12) 8.1s Passed
🟩 RunTask(diff:diff) 96.1ms Passed
🟩 RunTask(root:test) 1.5s Passed
🟩 RunTask(diff:test) 4.5s Passed
Touched files
.changeset/nice-bulldogs-walk.md
.vscode/launch.json
pnpm-lock.yaml
tools/diff-generator/README.md
tools/diff-generator/package.json
tools/diff-generator/src/lib/cli.js
tools/diff-generator/src/lib/file-import.js
tools/diff-generator/src/lib/format-function.js
tools/diff-generator/test/cli.test.js
tools/diff-generator/test/fileImport.test.js
tools/diff-generator/test/snapshots/cli.test.js.md
tools/diff-generator/test/snapshots/cli.test.js.snap
tools/diff-generator/test/snapshots/fileImport.test.js.md
tools/diff-generator/test/snapshots/fileImport.test.js.snap
tools/diff-generator/test/test-cli-outputs/expected-local-branch.txt

@GarthDB GarthDB merged commit c186fb8 into main Aug 29, 2024
4 checks passed
@GarthDB GarthDB deleted the garthdb/diff-generator-cli-local branch August 29, 2024 22:42
@GarthDB GarthDB mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants