Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2338

Merged
merged 3 commits into from
May 21, 2024
Merged

[Release] Stage to Main #2338

merged 3 commits into from
May 21, 2024

Conversation

@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented May 21, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner May 21, 2024 00:40
Copy link
Contributor

aem-code-sync bot commented May 21, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented May 21, 2024

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 82.92683% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 95.54%. Comparing base (24b60df) to head (75140af).
Report is 1 commits behind head on main.

Files Patch % Lines
libs/blocks/quiz-entry/quiz-entry.js 82.05% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
- Coverage   95.66%   95.54%   -0.12%     
==========================================
  Files         173      173              
  Lines       45055    45088      +33     
==========================================
- Hits        43103    43081      -22     
- Misses       1952     2007      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@JackySun9 JackySun9 requested review from colloyd, fullcolorcoder and a team May 21, 2024 04:05
@mokimo mokimo temporarily deployed to milo_pr_merge May 21, 2024 04:10 — with GitHub Actions Inactive
@JackySun9 JackySun9 added high priority Why is this a high priority? Blocker? Critical? Dependency? run-nala Run Nala Test Automation against PR labels May 21, 2024
@JackySun9 JackySun9 added verified PR has been E2E tested by a reviewer MIQ SOT👌 labels May 21, 2024
@JackySun9
Copy link
Contributor

Unit tests will be added in the user story: https://jira.corp.adobe.com/browse/MWPW-149369

@mokimo mokimo merged commit 18c77ef into main May 21, 2024
22 of 24 checks passed
@mokimo mokimo temporarily deployed to milo_pr_merge May 21, 2024 06:36 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CC SOT 👌 DC SOT 👌 high priority Why is this a high priority? Blocker? Critical? Dependency? Homepage SOT 👌 MIQ SOT👌 run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants