CC firefly product page UI, search integration with firefly web tests #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CC Merchtable block automation (JIra: MWPW-140978)
CC sticky promo bar, promo with close action automated test cases Jira : MWPW-140982, MWPW-142252
…eatures CC Regression automated cases for media rounded corners, breadcrumb features (MWPW-140976, MWPW-142543)
CC home page tabs, fragment reference , merch pod AU tests Jiras: https://jira.corp.adobe.com/browse/MWPW-143230 https://jira.corp.adobe.com/browse/MWPW-142599 https://jira.corp.adobe.com/browse/MWPW-143231
Key CC , CCT product pages sanity checks automation for EN https://jira.corp.adobe.com/browse/MWPW-146289
CC Tier1 locales production sanity tests https://jira.corp.adobe.com/browse/MWPW-146289
removed the lengthy URL
removed the space
removed tailing spaces from given lines
CC page Accordion features regression automated cases https://jira.corp.adobe.com/browse/MWPW-147151 https://jira.corp.adobe.com/browse/MWPW-147152 https://jira.corp.adobe.com/browse/MWPW-147153 https://jira.corp.adobe.com/browse/MWPW-147154
corrected the typo
fixed indentations issue at line 14,15,16 Also removed wait from line number 81
CC firefly product page UI & integration with FF web
JackySun9
approved these changes
Jun 3, 2024
Dli3
reviewed
Jun 3, 2024
Dli3
reviewed
Jun 3, 2024
Dli3
reviewed
Jun 3, 2024
Dli3
reviewed
Jun 3, 2024
Dli3
reviewed
Jun 3, 2024
Dli3
reviewed
Jun 3, 2024
Dli3
reviewed
Jun 3, 2024
tests/cc/firefly.test.js
Outdated
| await expect(page).toHaveURL(`${baseURL}${features[0].path}`); | ||
| }); | ||
| await test.step('search term take use to IMS and post login to FF product page', async () => { | ||
| await page.waitForLoadState(); |
There was a problem hiding this comment.
You're waiting for loadstate on line 14, you probably don't need another one.
Dli3
reviewed
Jun 4, 2024
tests/cc/firefly.test.js
Outdated
| expect(await firefly.searchPromptBox).toBeTruthy(); | ||
| expect(await firefly.generateCTA).toBeTruthy(); | ||
| await firefly.searchPromptBox.fill(features[0].term); | ||
| // await page.waitForTimeout(2000); |
There was a problem hiding this comment.
You can probably remove this comment if not needed.
Dli3
reviewed
Jun 4, 2024
tests/cc/firefly.test.js
Outdated
| await expect(page).toHaveURL(`${baseURL}${features[1].path}`); | ||
| }); | ||
| await test.step('user hits serach CTA with out search prompt', async () => { | ||
| await page.waitForLoadState(); |
There was a problem hiding this comment.
You're waiting for loadstate on line 35, you probably don't need another one.
Dli3
reviewed
Jun 4, 2024
tests/cc/firefly.test.js
Outdated
| await page.waitForLoadState('domcontentloaded'); | ||
| await expect(page).toHaveURL(`${baseURL}${features[2].path}`); | ||
| }); | ||
| await test.step('user hits serach CTA with out search prompt', async () => { |
There was a problem hiding this comment.
await test.step('user hits search CTA with out search prompt', async () => {
Typo fix.
Dli3
reviewed
Jun 4, 2024
tests/cc/firefly.test.js
Outdated
| await expect(page).toHaveURL(`${baseURL}${features[2].path}`); | ||
| }); | ||
| await test.step('user hits serach CTA with out search prompt', async () => { | ||
| await page.waitForLoadState(); |
There was a problem hiding this comment.
You're waiting for loadstate on line 51, you probably don't need another one.
removed unwanted wait
removed commented line
removed wait for load state line
typo fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC firefly product page UI, search integration with firefly web tests