fix graybox-cc screenshot tests #466
Conversation
| stableURL, | ||
| async () => { | ||
| await page.waitForLoadState('networkidle'); | ||
| await page.waitForTimeout(8000); |
There was a problem hiding this comment.
how arbitrary are these timeouts? Is there a better way for waiting on the page to fully load, like waiting for a specific element in the last section/block to load completely. Just wondering since there may be a potential for these timeouts to fluctuate.
There was a problem hiding this comment.
because we test different pages in CC, maybe we can find one, but when I test DC, I am not able to find one in all pages
There was a problem hiding this comment.
If it works, just a thought, you could make a parameter that allows you to send in an element to look for or by default if nothing is sent in use the arbitrary timeouts. Not a requirement, but could potentially help if the tests become flaky due to the timeouts.
| betaURL, | ||
| async () => { | ||
| await page.waitForLoadState('networkidle'); | ||
| await page.waitForTimeout(10000); |
There was a problem hiding this comment.
Same as above comment.
fix graybox-cc screenshot tests