Fix argument errors of LightService::LocalizationAdapter

[wqsaali]

Summary

This PR refactors the LocalizationAdapter and I18n::LocalizationAdapter classes to standardize the method interfaces for success and failure. The changes aim to unify how these methods are called and processed, regardless of which adapter is used.

Changes Introduced

1. Unified Method Signature:

   • Both success and failure methods now accept a third optional options argument in both LocalizationAdapter and I18n::LocalizationAdapter.

2. Improved Extensibility:

   • The added options argument allows for future extensibility without requiring interface changes.

Why This Change Was Made

• To create a unified interface for both adapters, simplifying their usage and improving maintainability.
• To provide flexibility for passing additional options (like i18n_options) without breaking existing functionality.

How It Works

• If a Symbol is passed to success or failure, it will be translated using either:
  • The LocalizationMap (for LocalizationAdapter)
  • The I18n translation system (for I18n::LocalizationAdapter)
• If a string is passed, it is returned as-is.
• The third options argument allows for additional customization during processing.

Testing

• Verified that the refactored methods work seamlessly for both adapters.
• Added test coverage for both adapters.

Impact

• The method interfaces are now consistent across both adapters, reducing potential integration issues.
• Backward-compatible with existing implementations.

This PR fixes following issues reported

• README's built-in localization adapter documentation has a bug #240
• ArgumentError for LightService::LocalizationAdapter #262

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.47%. Comparing base (aa27ba1) to head (6f164c7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
- Coverage   99.47%   99.47%   -0.01%     
==========================================
  Files          29       29              
  Lines         766      765       -1     
==========================================
- Hits          762      761       -1     
  Misses          4        4              

Flag	Coverage Δ
unittests	99.47% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adomokos]

Thank you! 💯