Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @japa/api-client 2.x and 3.x as peerDependency #43

Merged

Conversation

marcuspoehls
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • πŸ“ Dependency Update

πŸ“š Description

Add @japa/api-client version 3.x as a peer dependency. This may raise the question if the @japa/api-client should be listed in peer dependencies because it requires someone to add any new major version when released. I’m not familiar with peer dependencies in modern npm versions. Maybe it’s enough to have @japa/api-client as a dev dependency.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage thetutlage merged commit 9c2ba2d into adonisjs:develop Jan 29, 2025
1 check passed
@thetutlage
Copy link
Member

Thanks πŸ‘

@marcuspoehls marcuspoehls deleted the update-japa-apiclient-peerdependency branch January 29, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants