Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ember v5 by addin @ember/string to peerDependencies #547

Merged
merged 9 commits into from
Nov 29, 2024
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ jobs:
ember-try-scenario: [
ember-lts-3.20,
ember-lts-3.24,
ember-lts-4.12,
ember-lts-5.12,
# ember-release,
# ember-beta,
# ember-canary,
Expand Down
19 changes: 19 additions & 0 deletions config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ module.exports = async function () {
name: 'ember-lts-3.20',
npm: {
devDependencies: {
'@ember/string': '^3.0.0',
'ember-qunit': '6.0.0',
'ember-source': '~3.20.5',
},
Expand All @@ -20,11 +21,29 @@ module.exports = async function () {
name: 'ember-lts-3.24',
npm: {
devDependencies: {
'@ember/string': '^3.0.0',
'ember-qunit': '6.0.0',
'ember-source': '~3.24.3',
},
},
},
{
name: 'ember-lts-4.12',
npm: {
devDependencies: {
'ember-source': '~4.12.0',
},
},
},
{
name: 'ember-lts-5.12',
npm: {
devDependencies: {
'ember-resolver': '^12.0.0',
'ember-source': '~5.12.0',
},
},
},
{
name: 'ember-release',
npm: {
Expand Down
7 changes: 6 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
},
"devDependencies": {
"@ember/optional-features": "^2.0.0",
"@ember/string": "^4.0.0",
"@ember/test-helpers": "^2.4.2",
"@embroider/test-setup": "^2.0.0",
"@glimmer/tracking": "^1.0.4",
Expand Down Expand Up @@ -118,8 +119,12 @@
"typescript": "^4.4.3",
"webpack": "5"
},
"peerDependencies": {
"@ember/string": "^4.0.0"
},
"resolutions": {
"@babel/plugin-transform-modules-amd": "7.16.5"
"@babel/plugin-transform-modules-amd": "7.16.5",
"@ember/string": "^4.0.0"
},
"engines": {
"node": "18.* || 20.* || >= 22"
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -972,6 +972,11 @@
mkdirp "^1.0.4"
silent-error "^1.1.1"

"@ember/string@^4.0.0":
version "4.0.0"
resolved "https://registry.yarnpkg.com/@ember/string/-/string-4.0.0.tgz#24fe5cda227c9e6634e6e0b550944a3a13437878"
integrity sha512-IMVyVE72twuAMSYcHzWSgtgYTtzlHlKSGW8vEbztnnmkU6uo7kVHmiqSN9R4RkBhzvh0VD4G76Eph+55t3iNIA==

"@ember/test-helpers@*":
version "4.0.4"
resolved "https://registry.yarnpkg.com/@ember/test-helpers/-/test-helpers-4.0.4.tgz#2ffb55c8438b8ba54ecd4f546059ba0166bc00f2"
Expand Down
Loading