Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for node < 18 #548

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Nov 19, 2024

Drops support for all node versions, which reached end of life already.

Disabling test cases for Ember v5 and Embroider as the addon is not ready for it yet.

This is a breaking change.

@jelhan jelhan marked this pull request as draft November 19, 2024 14:18
@jelhan jelhan marked this pull request as ready for review November 19, 2024 14:24
@jelhan
Copy link
Contributor Author

jelhan commented Nov 20, 2024

I learned that there is a 2.0.0-beta.2 release, which supports Ember v5. The code is not in this repository. But it is available on NPM.

@jelhan jelhan closed this Nov 20, 2024
@jelhan
Copy link
Contributor Author

jelhan commented Nov 26, 2024

Reopening. The code for 2.0.0-beta.2 is in this repository. This is the tag: v2.0.0-beta.2

We should drop support for node 18 before releasing the new major.

@jelhan jelhan reopened this Nov 26, 2024
@knownasilya
Copy link
Contributor

@jelhan this ready to merge?

@jelhan
Copy link
Contributor Author

jelhan commented Nov 26, 2024

@jelhan this ready to merge?

Yes. It's ready from my side.

@knownasilya knownasilya merged commit 8a3a71c into adopted-ember-addons:master Nov 26, 2024
6 checks passed
@jelhan jelhan deleted the require-node-18 branch November 28, 2024 12:59
@github-actions github-actions bot mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants