Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prepack step to unblock release #551

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Dec 17, 2024

ember ts:precompile failed with the following error:

error TS2688: Cannot find type definition file for 'ember__test-helpers'.
  The file is in the program because:
    Entry point for implicit type library 'ember__test-helpers'


Found 1 error.

This is caused by @types/ember__test-helpers version 2.9.3 being a stub without including any actual types. Users should use the types provided by @ember/test-helpers. But those types are not provided by the old version used in this project.

ember ts:precompile is used as prepack step. This blocks releasing a new version.

@jelhan jelhan marked this pull request as ready for review December 17, 2024 19:47
@jelhan jelhan requested a review from SergeAstapov December 21, 2024 14:32
@kategengler kategengler force-pushed the fix-typescript-compilation branch from f40abf4 to 4ce97fa Compare February 26, 2025 23:21
@kategengler kategengler merged commit 8ae9751 into master Feb 26, 2025
6 checks passed
@github-actions github-actions bot mentioned this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants